52264[FEATURE] Allow extended custom links in FormEngine and TypoLink
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php2+37 −28
- typo3/sysext/core/Configuration/DefaultConfiguration.php+9 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-80619-ExtendLinkGenerationWithinTypolink.rstnew+29 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+28 −419
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php2new+196 −0
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php4new+76 −0
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.phpnew+31 −0
- typo3/sysext/frontend/Classes/Typolink/ExternalUrlLinkBuilder.phpnew+35 −0
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.phpnew+54 −0
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.phpnew+51 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.phpnew+316 −0
- typo3/sysext/frontend/Classes/Typolink/UnableToLinkException.phpnew+53 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −129
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.phpnew+237 −0
Review log 2843
Show 1218 earlier messages
-
Benni Mack uploaded patch set 1 03/30/17, 13:47
-
Benni Mack commented on patch set 1 03/30/17, 13:53
Still needs a PoC, documentation, and Interfaces for these calls. -
TYPO3com voted on patch set 1 V -1 03/30/17, 13:56 Completed build in 08m 41s on Thu, 30 Mar, 03:56 PM Test Summary: 6 of 56540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9964
-
Benni Mack uploaded patch set 2 03/31/17, 20:10
-
Benni Mack uploaded patch set 3 03/31/17, 20:12
-
TYPO3com voted on patch set 2 V -1 03/31/17, 20:20 Completed build in 10m 04s on Fri, 31 Mar, 10:20 PM Test Summary: 312 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10108
-
TYPO3com voted on patch set 3 V -1 03/31/17, 20:23 Completed build in 11m 21s on Fri, 31 Mar, 10:23 PM Test Summary: 312 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10109
-
Benni Mack uploaded patch set 4 03/31/17, 20:32
-
TYPO3com voted on patch set 4 V -1 03/31/17, 20:42 Completed build in 09m 54s on Fri, 31 Mar, 10:42 PM Test Summary: 192 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10111
-
Markus Klein commented on patch set 4 03/31/17, 20:45
InputLinkElement.php:402does that work at all??? I mean switch compares the given value with the case. that would be $linkData['type'] === isset() ? does not make sense -
Benni Mack commented on patch set 4 03/31/17, 20:50
InputLinkElement.php:402Replyyes, I started with this part, but then did not try that actually. will fix that part. -
Benni Mack uploaded patch set 5 03/31/17, 21:06
-
TYPO3com voted on patch set 5 V -1 03/31/17, 21:14 Completed build in 07m 59s on Fri, 31 Mar, 11:14 PM Test Summary: 192 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10117
-
Benni Mack uploaded patch set 6 03/31/17, 21:24
-
TYPO3com voted on patch set 6 V -1 03/31/17, 21:34 Completed build in 09m 26s on Fri, 31 Mar, 11:34 PM Test Summary: 192 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10122
-
Christian Kuhn commented on patch set 6 CR -1 04/02/17, 08:49
working on it. -
Elmar Hinz commented on patch set 6 CR -1 04/02/17, 09:37
This code is intended to by extended often. It should make the user happy. One criteria for me to easily work with sources is to be able to easily read them side by side. Can I easily read them side by side right here on https://review.typo3.org? No. Unfortunately not and it is freshly written. It enforces a lot of unnecessary horizontal scrolling with as standard laptop. The TYPO3 coding guidelines say 130 characters are fine. PSR2 says: Lines SHOULD NOT be longer than 80 characters. There are reason for this: The code should make the user happy. -
Christian Kuhn uploaded patch set 7 04/02/17, 10:07
-
Christian Kuhn voted on patch set 7 CR -2 04/02/17, 10:08
-
TYPO3com voted on patch set 7 V -1 04/02/17, 10:15 Completed build in 08m 17s on Sun, 2 Apr, 12:15 PM Test Summary: 126 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10138
-
Christian Kuhn uploaded patch set 8 04/02/17, 10:47
-
Christian Kuhn uploaded patch set 9 04/02/17, 10:49
-
Christian Kuhn uploaded patch set 10 04/02/17, 10:54
-
TYPO3com voted on patch set 8 V -1 04/02/17, 10:56 Completed build in 09m 06s on Sun, 2 Apr, 12:56 PM Test Summary: 18 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10140
-
TYPO3com voted on patch set 9 V -1 04/02/17, 10:57 Completed build in 07m 27s on Sun, 2 Apr, 12:57 PM Test Summary: 18 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10141
-
Christian Kuhn uploaded patch set 11 04/02/17, 10:59
-
TYPO3com voted on patch set 10 V -1 04/02/17, 11:03 Completed build in 08m 12s on Sun, 2 Apr, 01:03 PM Test Summary: 18 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10142
-
TYPO3com voted on patch set 11 V -1 04/02/17, 11:06 Completed build in 06m 58s on Sun, 2 Apr, 01:06 PM Test Summary: 18 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10143
-
Christian Kuhn uploaded patch set 12 04/02/17, 11:28
-
TYPO3com voted on patch set 12 V -1 04/02/17, 11:38 Completed build in 10m 07s on Sun, 2 Apr, 01:38 PM Test Summary: 6 of 56563 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10146
-
Christian Kuhn uploaded patch set 13 04/02/17, 11:41
-
TYPO3com voted on patch set 13 V +1 04/02/17, 11:50 Completed build in 08m 47s on Sun, 2 Apr, 01:50 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10147
-
Christian Kuhn commented on patch set 13 CR 0 04/02/17, 11:50
green, finally. now testing. -
Christian Kuhn uploaded patch set 14 04/02/17, 12:10
-
Markus Klein commented on patch set 13 04/02/17, 12:15
AbstractTypolinkBuilder.php:38typehint pleaseDatabaseRecordLinkBuilder.php:24shouldn't there be an interface for this? TypoLinkBuilderInterfaceDatabaseRecordLinkBuilder.php:27according to http://stackoverflow.com/questions/26550745/correct-syntax-for-inheritdoc-in-phpdocumentor this should be @inheritDoc (or left out at all) -
Christian Kuhn voted on patch set 14 CR -1 04/02/17, 12:18
-
TYPO3com voted on patch set 14 V +1 04/02/17, 12:19 Completed build in 08m 37s on Sun, 2 Apr, 02:19 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10151
-
Christian Kuhn commented on patch set 13 04/02/17, 12:26
AbstractTypolinkBuilder.php:38ReplyDoneDatabaseRecordLinkBuilder.php:24Replyno. with this late feature we have to do now 2 days before release since the link handler feature came in half-baked, i'd say let's better not add an interface right now and maybe do that later if this structure proofs to work out well.DatabaseRecordLinkBuilder.php:27Replysorry, i don't really care about this at this point in time. feel free to improve that later. -
Christian Kuhn uploaded patch set 15 04/02/17, 12:29
-
TYPO3com voted on patch set 15 V +1 04/02/17, 12:39 Completed build in 09m 34s on Sun, 2 Apr, 02:39 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10152
-
Christian Kuhn voted on patch set 15 CR +1 V +1 04/02/17, 12:40
-
Frank Nägler voted on patch set 15 CR +2 V +2 04/02/17, 12:46
-
Gerrit merged patch set 15 04/02/17, 12:46