Review main Merged

52269[TASK] Resolve hidden dependency from EXT:backend to EXT:rsaauth

Claus Due CR +2 V +2 Easy +9 −5 updated 05/09/17, 06:55

Commit message

Moves always-executed code into a hook which only executes
if the rsaauth extension is installed.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Thomas Hohn +1
    • Oliver Klee +1
    • Kasper Ligaard +1
    • Wouter Wolters +1
    • Jan Helke +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2428

Show 23 earlier messages
  1. Claus Due uploaded patch set 1 03/30/17, 18:07

  2. TYPO3com voted on patch set 1 V -1 03/30/17, 18:16 Completed build in 09m 26s on Thu, 30 Mar, 08:16 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9972

  3. Christian Kuhn commented on patch set 1 03/30/17, 22:36

    RsaEncryptionEncoder.php:40

    some comment stating this method is called by a hook.
  1. Stefan Neufeind commented on patch set 1 03/31/17, 06:12

    BackendController.php:35

    codestyle-checker says drop the RsaEncryptionEncoder-import here since it's unused

    RsaEncryptionEncoder.php:40

    codestyle-checker demands to skip the "@return void" here
  2. Mathias Brodala updated the commit message in patch set 2 03/31/17, 07:18

  3. Wouter Wolters commented on patch set 3 03/31/17, 07:21

    Published edit on patch set 2.
  4. TYPO3com voted on patch set 2 V -1 03/31/17, 07:29 Completed build in 10m 35s on Fri, 31 Mar, 09:29 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10014

  5. TYPO3com voted on patch set 3 V -1 03/31/17, 07:33 Completed build in 12m 03s on Fri, 31 Mar, 09:33 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10015

  6. Wouter Wolters commented on patch set 4 03/31/17, 07:34

    Published edit on patch set 3.
  7. TYPO3com voted on patch set 4 V +1 03/31/17, 07:43 Completed build in 09m 05s on Fri, 31 Mar, 09:43 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10019

  8. Thomas Hohn voted on patch set 4 CR +1 03/31/17, 07:56

  9. Stefan Neufeind voted on patch set 4 CR +1 03/31/17, 08:13

  10. Wouter Wolters voted on patch set 4 CR +1 03/31/17, 08:49

  11. Kasper Ligaard voted on patch set 4 CR +1 04/10/17, 09:00

  12. Andreas Kienast voted on patch set 4 CR +1 05/05/17, 11:27

  13. Oliver Klee voted on patch set 4 CR +1 05/05/17, 12:07

  14. Jan Helke voted on patch set 4 CR +1 V +1 05/05/17, 16:53

  15. Markus Klein voted on patch set 4 CR +2 V +2 05/05/17, 18:21

  16. Gerrit merged patch set 4 05/05/17, 18:21

  17. Helmut Hummel commented on patch set 5 05/05/17, 18:48

    nice one!
  18. Kasper Ligaard commented on patch set 5 05/06/17, 08:40

    It would be nice to have this in TYPO3 8 LTS too.
  19. Helmut Hummel commented on patch set 5 05/06/17, 09:22

    I wouldn't object to have this in 8
  20. Markus Klein commented on patch set 5 05/06/17, 09:40

    When I thought about a backport before merge, I thought of this as rather a stylistic change. I see no benefit from this change in 8. When we get the subtree split in 9, this of course is a bugfix.
  21. Helmut Hummel commented on patch set 5 05/06/17, 09:46

    what happens if rsaauth is not activated? The class is there, but the code probably does nothing or does something which is not wanted. I assume this is a valid bugfix for the case rsaauth is not active even for 7.6 (if applicable)
  22. Markus Klein commented on patch set 5 05/06/17, 09:54

    I just tried it out. uninstalled rsaauth, set loginSecLevel to normal. Works without issues. (The class is of course still loadable and no side effects can be noticed) That's why I don't see it as a bug for 7 and 8
  23. Kasper Ligaard commented on patch set 5 05/06/17, 10:14

    I concur with Helmut and would like to invoke the principle of least astonishment here. Although it might work now there could later be introduced things in the class. For a user not needing RSA auth it would seem weird that changes on a for him unrelated extension should impact his setup. Also, this patch was originally made before TYPO3 8 LTS, so I think it should go in there.
  24. Markus Klein commented on patch set 5 05/06/17, 12:09

    Go head then. I have no veto against it nor do I have very strong opinion. ;-)
  25. Kasper Ligaard commented on patch set 5 05/09/17, 06:55

    Backport for 8.7 available in https://review.typo3.org/#/c/52739/