Review main Merged

52271[TASK] Deprecate TYPO3_CONF_VARS_extensionAdded

Christian Kuhn CR +2 V +2 Normal +44 −8 updated 03/30/17, 20:45

Commit message

The global array $GLOBALS['TYPO3_CONF_VARS_extensionAdded'] is widely
unknown and of little use.
Deprecate it along with helper method
ExtensionManagementUtility::appendToTypoConfVars()

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 03/30/17, 19:56

  2. TYPO3com voted on patch set 1 V -1 03/30/17, 20:08 Completed build in 11m 46s on Thu, 30 Mar, 10:08 PM Test Summary: 2 of 56536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9984

  3. Christian Kuhn voted on patch set 1 CR -1 03/30/17, 20:27

  4. Christian Kuhn uploaded patch set 2 03/30/17, 20:33

  5. Andreas Kienast commented on patch set 1 CR -1 03/30/17, 20:33

    will push a fix
  6. Andreas Kienast commented on patch set 2 CR +1 V +1 03/30/17, 20:33

    Ok, lolli was faster :-)
  7. TYPO3com voted on patch set 2 V +1 03/30/17, 20:44 Completed build in 11m 35s on Thu, 30 Mar, 10:44 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9987

  8. Benni Mack voted on patch set 2 CR +2 V +2 03/30/17, 20:45

  9. Gerrit merged patch set 2 03/30/17, 20:45