Review main Merged

52275[BUGFIX] FAL: Correctly iterate folder content with offset

Markus Klein CR +2 V +2 Easy +9 −7 updated 03/31/17, 10:27

Commit message

Whenever a list of files of a folder is queried with an offset
make sure we handle filtered files correctly by not taking them
into account when searching for the first eligible file for the
result.

A direct seek() to the start position is wrong as those first files
may contain files would be later on filtered.
The solution is to iterate the whole file list and only count
non-filtered elements to reach the correct starting point.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • Frans Saris +1
    • Andreas Kienast +1
  • Verified V +2
    • Jigal van Hemert +2
    • Riccardo De Contardi +1
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Markus Klein uploaded patch set 1 03/30/17, 22:07

  2. TYPO3com voted on patch set 1 V +1 03/30/17, 22:16 Completed build in 09m 11s on Fri, 31 Mar, 12:16 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9998

  3. Riccardo De Contardi commented on patch set 1 V +1 03/30/17, 22:27

    tested on master; seems to work
  4. Frans Saris voted on patch set 1 CR +1 V +1 03/31/17, 06:17

  5. Wouter Wolters voted on patch set 1 CR +1 03/31/17, 06:53

  6. Jigal van Hemert voted on patch set 1 CR +1 V +1 03/31/17, 10:02

  7. Jigal van Hemert voted on patch set 1 CR +2 V +2 03/31/17, 10:16

  8. Andreas Kienast voted on patch set 1 CR +1 03/31/17, 10:18

  9. Gerrit merged patch set 1 03/31/17, 10:18

  10. Markus Klein commented on patch set 2 03/31/17, 10:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 9a8b82ddda23e83dc1d4a337cecb1e80a6782768