Review main Merged

52277[FOLLOWUP][TASK] Restructure typolink tag generation

Benni Mack CR +2 V +2 Easy +9 −17 updated 03/31/17, 00:15

Commit message

The JSwindowParams was not initialized anymore at right place and is moved.

Additionally, the overhead for recurring aTagParams and URL has been moved outside
of the switch/case statement, as it was a leftover of the restructuring.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 03/30/17, 23:20

  2. TYPO3com voted on patch set 1 V +1 03/30/17, 23:29 Completed build in 09m 22s on Fri, 31 Mar, 01:29 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10005

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 03/30/17, 23:44

  4. Mona Muzaffar voted on patch set 1 CR +1 V +1 03/31/17, 00:05

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 03/31/17, 00:15

  6. Gerrit merged patch set 1 03/31/17, 00:15