Review main Merged

52285[TASK] Change duplicate icon identifiers to actions-close

Marco Christian Krenn CR +2 V +2 Normal +57 −20 updated 03/31/17, 12:58

Commit message

The following icons which were previously used in the Install tool
were all replaced by "actions-close" which acts as a synonym.

* actions-document-close
* actions-message-error-close

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Frank Nägler +1
  • Verified V +2
    • Benjamin Kott +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 1217

  1. Marco Christian Krenn uploaded patch set 1 03/31/17, 10:16

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 03/31/17, 10:18

  3. Thomas Hohn updated the commit message in patch set 2 03/31/17, 10:24

  4. Marco Christian Krenn commented on patch set 2 CR -1 03/31/17, 10:25

    still working on it
  5. TYPO3com voted on patch set 1 V +1 03/31/17, 10:29 Completed build in 12m 54s on Fri, 31 Mar, 12:29 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10042

  6. Thomas Hohn commented on patch set 2 03/31/17, 10:42

    The please [WIP] :-)
  7. Marco Christian Krenn uploaded patch set 3 03/31/17, 10:43

  8. Benni Mack updated the commit message in patch set 4 03/31/17, 10:47

  9. TYPO3com voted on patch set 2 V +1 03/31/17, 10:48 Completed build in 24m 52s on Fri, 31 Mar, 12:48 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10045

  10. TYPO3com voted on patch set 3 V +1 03/31/17, 11:07 Completed build in 23m 18s on Fri, 31 Mar, 01:07 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10052

  11. TYPO3com voted on patch set 4 V +1 03/31/17, 11:08 Completed build in 20m 40s on Fri, 31 Mar, 01:08 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10053

  12. Thomas Hohn commented on patch set 4 03/31/17, 11:13

    ExtdirectTreeDataProvider.php:188

    Ist this not an error?
  13. Frank Nägler uploaded patch set 5 03/31/17, 12:45

  14. Frank Nägler voted on patch set 5 CR +1 V +1 03/31/17, 12:46

  15. TYPO3com voted on patch set 5 V +1 03/31/17, 12:55 Completed build in 10m 02s on Fri, 31 Mar, 02:55 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10060

  16. Benjamin Kott voted on patch set 5 CR +2 V +2 03/31/17, 12:57

  17. Gerrit merged patch set 5 03/31/17, 12:58