52285[TASK] Change duplicate icon identifiers to actions-close
Commit message
Review
-
Code review CR +2
- Benjamin Kott +2
- Frank Nägler +1
-
Verified V +2
- Benjamin Kott +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 17
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Clipboard/Main.html+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php+2 −2
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+1 −1
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+6 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-80601-ChangeActions-document-closeToActions-close.rstnew+32 −0
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js+1 −1
- typo3/sysext/lang/Classes/Controller/LanguageController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/Wizard/RteController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −1
Review log 1217
-
Marco Christian Krenn uploaded patch set 1 03/31/17, 10:16
-
Benjamin Kott voted on patch set 1 CR +1 V +1 03/31/17, 10:18
-
Thomas Hohn updated the commit message in patch set 2 03/31/17, 10:24
-
Marco Christian Krenn commented on patch set 2 CR -1 03/31/17, 10:25
still working on it -
TYPO3com voted on patch set 1 V +1 03/31/17, 10:29 Completed build in 12m 54s on Fri, 31 Mar, 12:29 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10042
-
Thomas Hohn commented on patch set 2 03/31/17, 10:42
The please [WIP] :-) -
Marco Christian Krenn uploaded patch set 3 03/31/17, 10:43
-
Benni Mack updated the commit message in patch set 4 03/31/17, 10:47
-
TYPO3com voted on patch set 2 V +1 03/31/17, 10:48 Completed build in 24m 52s on Fri, 31 Mar, 12:48 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10045
-
TYPO3com voted on patch set 3 V +1 03/31/17, 11:07 Completed build in 23m 18s on Fri, 31 Mar, 01:07 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10052
-
TYPO3com voted on patch set 4 V +1 03/31/17, 11:08 Completed build in 20m 40s on Fri, 31 Mar, 01:08 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10053
-
Thomas Hohn commented on patch set 4 03/31/17, 11:13
ExtdirectTreeDataProvider.php:188Ist this not an error? -
Frank Nägler uploaded patch set 5 03/31/17, 12:45
-
Frank Nägler voted on patch set 5 CR +1 V +1 03/31/17, 12:46
-
TYPO3com voted on patch set 5 V +1 03/31/17, 12:55 Completed build in 10m 02s on Fri, 31 Mar, 02:55 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10060
-
Benjamin Kott voted on patch set 5 CR +2 V +2 03/31/17, 12:57
-
Gerrit merged patch set 5 03/31/17, 12:58