Review TYPO3_6-2 Merged

52288[BUGFIX] FAL: Correctly iterate folder content with offset

Markus Klein CR +2 V +2 Easy +9 −7 updated 03/31/17, 10:38

Commit message

Whenever a list of files of a folder is queried with an offset
make sure we handle filtered files correctly by not taking them
into account when searching for the first eligible file for the
result.

A direct seek() to the start position is wrong as those first files
may contain files would be later on filtered.
The solution is to iterate the whole file list and only count
non-filtered elements to reach the correct starting point.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Markus Klein uploaded patch set 1 03/31/17, 10:28

  2. TYPO3com voted on patch set 1 V +1 03/31/17, 10:37 Completed build in 08m 59s on Fri, 31 Mar, 12:37 PM Test Summary: 30896 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-121

  3. Markus Klein voted on patch set 1 CR +2 V +2 03/31/17, 10:38

  4. Gerrit merged patch set 1 03/31/17, 10:38