Review main Abandoned

52297[TASK] Loosen the version restriction for testing-framework

Anja Leichsenring CR 0 V 0 Easy +2 −2 updated 04/03/17, 07:15

Commit message

Fix only the major version constraint.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 710

  1. Anja Leichsenring uploaded patch set 1 03/31/17, 16:33

  2. TYPO3com voted on patch set 1 V -1 03/31/17, 16:33 Completed build in 06s on Fri, 31 Mar, 06:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10083

  3. Anja Leichsenring uploaded patch set 2 03/31/17, 16:38

  4. TYPO3com voted on patch set 2 V +1 03/31/17, 16:47 Completed build in 08m 56s on Fri, 31 Mar, 06:47 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10084

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 03/31/17, 16:47

  6. Anja Leichsenring updated the commit message in patch set 3 03/31/17, 16:51

  7. Benjamin Kott voted on patch set 3 CR +1 V +1 03/31/17, 16:52

  8. TYPO3com voted on patch set 3 V +1 03/31/17, 17:02 Completed build in 11m 04s on Fri, 31 Mar, 07:02 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10085

  9. Anja Leichsenring abandoned the change 03/31/17, 17:31

  10. Mathias Brodala commented on patch set 3 04/03/17, 07:15

    composer.json:56

    The idea itself is good and I'd even go as far as use "^1.0" because that's what Composer will use by default anyways.