Review main Merged

52299[TASK] Move rst changelog files from master to 8.7 folder

Frank Nägler CR +2 V +2 Expert +610 −540 updated 04/02/17, 16:35

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 80

Show 60 more files

Review log 1218

  1. Frank Nägler uploaded patch set 1 03/31/17, 18:28

  2. TYPO3com voted on patch set 1 V +1 03/31/17, 18:37 Completed build in 09m 11s on Fri, 31 Mar, 08:37 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10090

  3. Wouter Wolters updated the commit message in patch set 2 03/31/17, 18:39

  4. TYPO3com voted on patch set 2 V +1 03/31/17, 18:55 Completed build in 15m 14s on Fri, 31 Mar, 08:55 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10092

  5. Riccardo De Contardi commented on patch set 1 03/31/17, 19:26

    I set some notes

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:20

    doesn't (maybe better does not? doesn't is more used in spoken form AFAIK)

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:44

    see previous comment

    Deprecation-78650-TemplateService-splitConfArray.rst:12

    missing: 'was' or 'has been'

    Feature-80126-ExtFormSetMaximumFieldLengthAsAttribute.rst:13

    ?? maybe 'use' only?

    Feature-80579-ImprovedJavaScriptModalAPI.rst:221

    length

    Important-80241-ExtFormSimplifyTranslationHandling.rst:52

    sounds better 'to define only the new keys' IMO
  6. Frank Nägler commented on patch set 1 03/31/17, 20:00

    thx Ricardo

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:20 Reply

    Done

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:44 Reply

    Done

    Deprecation-78650-TemplateService-splitConfArray.rst:12 Reply

    Done
  7. Frank Nägler uploaded patch set 3 03/31/17, 20:01

  8. Riccardo De Contardi commented on patch set 3 03/31/17, 20:06

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:44

    my comment was not clear enough :( My concern was about the contraption 'wasn't' > 'was not' :) here 'wasn't' is correct
  9. TYPO3com voted on patch set 3 V +1 03/31/17, 20:13 Completed build in 11m 53s on Fri, 31 Mar, 10:13 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10107

  10. Frank Nägler uploaded patch set 4 04/02/17, 12:53

  11. TYPO3com voted on patch set 4 V +1 04/02/17, 13:06 Completed build in 12m 52s on Sun, 2 Apr, 03:06 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10155

  12. Frank Nägler uploaded patch set 5 04/02/17, 14:00

  13. TYPO3com voted on patch set 5 V +1 04/02/17, 14:08 Completed build in 08m 10s on Sun, 2 Apr, 04:08 PM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10160

  14. Riccardo De Contardi commented on patch set 5 04/02/17, 14:12

    Breaking-80171-RemoveLibparseFunc_RTEInlineStylesFromParsedBlockquoteTag.rst:44

    please use wasn't or was not. See my comment for patch 3
  15. Christian Kuhn uploaded patch set 6 04/02/17, 16:08

  16. TYPO3com voted on patch set 6 V +1 04/02/17, 16:16 Completed build in 07m 52s on Sun, 2 Apr, 06:16 PM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10168

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 04/02/17, 16:28

  18. Gerrit merged patch set 6 04/02/17, 16:35