52311[BUGFIX] Replace .env parsing with reading from environment
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Jan Helke +1
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Jan Helke +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1620
-
Helmut Hummel uploaded patch set 1 04/01/17, 14:25
-
Helmut Hummel updated the commit message in patch set 2 04/01/17, 14:33
-
TYPO3com voted on patch set 1 V +1 04/01/17, 14:34 Completed build in 08m 47s on Sat, 1 Apr, 04:34 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10132
-
TYPO3com voted on patch set 2 V +1 04/01/17, 14:41 Completed build in 08m 06s on Sat, 1 Apr, 04:41 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10133
-
Benjamin Franzke commented on patch set 2 V +1 04/01/17, 18:13
Thanks a lot, that should really be removed/changed before the LTS release.DatabaseConnect.php:312There was previously a variable for the database name. That's dropped here. On purpose?ConnectDetails.html:29The option text should also be changed to "Configuration from environment" -
Helmut Hummel commented on patch set 2 04/02/17, 11:18
DatabaseConnect.php:312Replyyes. I had it in there in the first iteration and then realized, that it wasn't needed at all here.ConnectDetails.html:29Replyah, of course, good point. thanks. -
Helmut Hummel uploaded patch set 3 04/02/17, 11:27
-
Helmut Hummel commented on patch set 2 04/02/17, 11:27
ConnectDetails.html:29ReplyDone -
TYPO3com voted on patch set 3 V +1 04/02/17, 11:36 Completed build in 09m 16s on Sun, 2 Apr, 01:36 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10145
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 04/02/17, 15:23
-
Christian Kuhn commented on patch set 3 CR -1 04/02/17, 16:02
DatabaseConnect.php:312dbname missing - this one is possible here for instance in postgres instances where dbname is required for successful connect. -
Helmut Hummel uploaded patch set 4 04/02/17, 20:32
-
Helmut Hummel commented on patch set 4 04/02/17, 20:40
added dbname again. I didn't know postgress also needs the dbname for a successful connection -
TYPO3com voted on patch set 4 V +1 04/02/17, 20:42 Completed build in 09m 46s on Sun, 2 Apr, 10:42 PM Test Summary: 56544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10185
-
Markus Klein commented on patch set 4 04/02/17, 21:02
IMO the original patch already lacked proper rst documentation for this feature!DatabaseConnect.php:313is this change intended? -
Helmut Hummel commented on patch set 4 04/03/17, 07:33
DatabaseConnect.php:313Replyyes. I think it is cleaner to have the additional INSTALL prefix here. -
Jan Helke voted on patch set 4 CR +1 V +1 04/03/17, 11:02
-
Christian Kuhn voted on patch set 4 CR +1 V +1 04/03/17, 11:04
-
Frank Nägler voted on patch set 4 CR +2 V +2 04/03/17, 11:05
-
Gerrit merged patch set 4 04/03/17, 11:05