Review main Merged

52322[BUGFIX] Ensure module menu can be expanded again

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 04/03/17, 11:29

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Daniel Goerz uploaded patch set 1 04/02/17, 22:59

  2. Markus Klein commented on patch set 1 04/02/17, 23:05

    ModuleMenu.js:54

    can you please check, why this holds the value 'true' and not a boolean value? what happens if you flush your user settings (uc)? We just fixed something in this area and I really hoped that storing bool in the user settings would also return bool here at this point
  3. TYPO3com voted on patch set 1 V +1 04/02/17, 23:10 Completed build in 10m 31s on Mon, 3 Apr, 01:10 AM Test Summary: 56544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10193

  4. Daniel Goerz commented on patch set 1 04/02/17, 23:13

    ModuleMenu.js:54 Reply

    I did that. UC holds {s:17:"typo3-module-menu";a:1:{s:9:"collapsed";s:5:"false";}}. In JS typeof state.collapsed gives "String". Can't you reproduce it?
  5. Thomas Hohn commented on patch set 1 CR +1 V +1 04/03/17, 04:56

    Just testet it - before Patch Module Menu stays collapsed on reload if collapsed once - after patch it's fine.
  6. Jörg Bösche voted on patch set 1 CR +1 04/03/17, 06:35

  7. Riccardo De Contardi voted on patch set 1 V +1 04/03/17, 07:43

  8. Christian Kuhn voted on patch set 1 CR +2 V +2 04/03/17, 11:29

  9. Gerrit merged patch set 1 04/03/17, 11:29