52332[BUGFIX] Fix position of delete icon in inspector panel of form module
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Björn Jacob +1
- Ralf Zimmermann +1
-
Verified V +2
- Frank Nägler +2
- Björn Jacob +1
- Ralf Zimmermann +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 89
-
Andreas Steiger uploaded patch set 1 04/03/17, 10:31
-
TYPO3com voted on patch set 1 V +1 04/03/17, 10:40 Completed build in 08m 48s on Mon, 3 Apr, 12:40 PM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10212
-
Ralf Zimmermann voted on patch set 1 CR +1 V +1 04/03/17, 11:44
-
Björn Jacob voted on patch set 1 CR +1 V +1 04/03/17, 12:09
-
Frank Nägler commented on patch set 1 CR -1 04/03/17, 12:28
I would recommend that the delete icon scroll out of the viewport. The flying delete icon has no benefit and the connection between the delete icon and the field get lost. -
Ralf Zimmermann commented on patch set 1 04/03/17, 12:32
This fix tries to do exactly what you mentioned. At the moment, the icon does not scroll out of the viewport. Instead it "flies" on scoll which is not wanted. -
Ralf Zimmermann commented on patch set 1 04/03/17, 12:33
*on scroll* -
Frank Nägler commented on patch set 1 CR +2 V +2 04/03/17, 12:49
sry, my mistake, fix is ok -
Gerrit merged patch set 1 04/03/17, 12:49