Review main Merged

52332[BUGFIX] Fix position of delete icon in inspector panel of form module

Andreas Steiger CR +2 V +2 Easy +3 −2 updated 04/03/17, 12:49

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
  • Verified V +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Andreas Steiger uploaded patch set 1 04/03/17, 10:31

  2. TYPO3com voted on patch set 1 V +1 04/03/17, 10:40 Completed build in 08m 48s on Mon, 3 Apr, 12:40 PM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10212

  3. Ralf Zimmermann voted on patch set 1 CR +1 V +1 04/03/17, 11:44

  4. Björn Jacob voted on patch set 1 CR +1 V +1 04/03/17, 12:09

  5. Frank Nägler commented on patch set 1 CR -1 04/03/17, 12:28

    I would recommend that the delete icon scroll out of the viewport. The flying delete icon has no benefit and the connection between the delete icon and the field get lost.
  6. Ralf Zimmermann commented on patch set 1 04/03/17, 12:32

    This fix tries to do exactly what you mentioned. At the moment, the icon does not scroll out of the viewport. Instead it "flies" on scoll which is not wanted.
  7. Ralf Zimmermann commented on patch set 1 04/03/17, 12:33

    *on scroll*
  8. Frank Nägler commented on patch set 1 CR +2 V +2 04/03/17, 12:49

    sry, my mistake, fix is ok
  9. Gerrit merged patch set 1 04/03/17, 12:49