Review main Merged

52334[BUGFIX] Allow editing of yaml files in the backend

Ingo Pfennigstorf CR +2 V +2 Easy +1 −1 updated 04/05/17, 18:18

Commit message

This adds the yaml file extension to the known textfile extensions for
the backend, so that i.e. form manifests are editable in the backend.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Jörg Bösche +1
    • Cedric Ziel +1
    • Mathias Brodala +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1719

  1. Ingo Pfennigstorf uploaded patch set 1 04/03/17, 11:38

  2. TYPO3com voted on patch set 1 V +1 04/03/17, 11:48 Completed build in 10m 44s on Mon, 3 Apr, 01:48 PM Test Summary: 56580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10224

  3. Cedric Ziel voted on patch set 1 CR +1 V +1 04/03/17, 12:25

  4. Mathias Brodala commented on patch set 1 04/03/17, 12:30

    DefaultConfiguration.php:87

    I guess "yml" should be added then, too for consistency.
  5. Frans Saris commented on patch set 1 04/03/17, 12:32

    DefaultConfiguration.php:87 Reply

    IMO yaml is enough as that's the default file extension we use
  6. Frans Saris voted on patch set 1 CR +1 V +1 04/03/17, 12:32

  7. Frans Saris commented on patch set 1 04/03/17, 12:33

    I guess this is more a task then a bugfix.
  8. Mathias Brodala commented on patch set 1 04/03/17, 12:34

    DefaultConfiguration.php:87 Reply

    I didn't mean the mentioned usecase (form) but more in general. See "html" and "htm" for example.
  9. Ingo Pfennigstorf commented on patch set 1 04/03/17, 12:42

    @Mathias .htm may be removed. Haven't seen it in years.
  10. Ingo Pfennigstorf commented on patch set 2 04/03/17, 12:47

    Published edit on patch set 1.
  11. Mathias Brodala voted on patch set 2 CR +1 04/03/17, 12:51

  12. TYPO3com voted on patch set 2 V +1 04/03/17, 12:57 Completed build in 09m 49s on Mon, 3 Apr, 02:57 PM Test Summary: 56574 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10234

  13. Stefan Neufeind voted on patch set 2 CR +1 04/03/17, 12:59

  14. Jörg Bösche voted on patch set 2 CR +1 04/03/17, 13:09

  15. Benni Mack voted on patch set 2 CR +2 04/03/17, 13:15

  16. Cedric Ziel voted on patch set 2 CR +1 04/03/17, 13:17

  17. Benni Mack voted on patch set 2 V +1 04/03/17, 13:17

  18. Wouter Wolters voted on patch set 2 CR +2 V +2 04/05/17, 18:18

  19. Gerrit merged patch set 2 04/05/17, 18:18