Review main Merged

52335[BUGFIX] EXT:form - let the CountValidator provide its arguments

Ralf Zimmermann CR +2 V +2 Easy +3 −3 updated 04/27/17, 14:52

Commit message

* Provide the validator's arguments to TYPO3\CMS\Extbase\Validation\Error
* Prevent PHP errors if sprintf is tried to be called in case of empty
  argument arrays

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2025

  1. Ralf Zimmermann uploaded patch set 1 04/03/17, 11:41

  2. TYPO3com voted on patch set 1 V +1 04/03/17, 11:52 Completed build in 10m 58s on Mon, 3 Apr, 01:52 PM Test Summary: 56580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10225

  3. Björn Jacob updated the commit message in patch set 2 04/03/17, 13:50

  4. TYPO3com voted on patch set 2 V +1 04/03/17, 14:00 Completed build in 10m 11s on Mon, 3 Apr, 04:00 PM Test Summary: 56574 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10240

  5. Stefan Neufeind voted on patch set 2 CR +1 V +1 04/04/17, 02:03

  6. Henrik Elsner voted on patch set 2 CR +1 04/11/17, 09:43

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/16/17, 12:37

  8. Björn Jacob voted on patch set 2 CR +1 V +1 04/16/17, 12:45

  9. Riccardo De Contardi commented on patch set 2 04/16/17, 15:28

    locallang.xlf:89

    I would prefer 'until' which is more formal or 'select %s to %s elements'
  10. Stefan Neufeind commented on patch set 2 04/17/17, 11:29

    Let's update the language-file and finally revote.

    locallang.xlf:89 Reply

    I agree. Please update and let's revote this. Only a small thing stopping us from having this in imho.
  11. Ralf Zimmermann commented on patch set 3 04/17/17, 11:37

    Published edit on patch set 2.
  12. TYPO3com voted on patch set 3 V +1 04/17/17, 11:45 Completed build in 07m 27s on Mon, 17 Apr, 01:45 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10622

  13. Stefan Neufeind voted on patch set 3 CR +1 V +1 04/17/17, 21:16

  14. Björn Jacob voted on patch set 3 CR +1 V +1 04/18/17, 04:39

  15. Björn Jacob commented on patch set 4 04/20/17, 06:08

    Published edit on patch set 3.
  16. Björn Jacob commented on patch set 4 CR +1 V +1 04/20/17, 06:09

    I have checked back with a native speaker. "to" is way better and in this context correct.
  17. Björn Jacob updated the commit message in patch set 5 04/20/17, 06:18

  18. Björn Jacob voted on patch set 5 CR +1 V +1 04/20/17, 06:18

  19. TYPO3com voted on patch set 4 V +1 04/20/17, 06:20 Completed build in 12m 13s on Thu, 20 Apr, 08:20 AM Test Summary: 56132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10740

  20. Andreas Kienast voted on patch set 5 CR +1 04/20/17, 06:21

  21. TYPO3com voted on patch set 5 V +1 04/20/17, 06:28 Completed build in 10m 07s on Thu, 20 Apr, 08:28 AM Test Summary: 56132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10741

  22. Stefan Neufeind commented on patch set 5 CR +1 V +1 04/20/17, 06:41

    reviewed; re-applied the verified-vote (since nothing major changed meanwhile)
  23. Wouter Wolters voted on patch set 5 CR +2 V +2 04/27/17, 14:52

  24. Gerrit merged patch set 5 04/27/17, 14:52

  25. Wouter Wolters commented on patch set 6 04/27/17, 14:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f2e4d184dcf6887993eb700485581148b8af515a