Review main Merged

52349[BUGFIX] Enable class/data-* attributes in RTE elements

Benni Mack CR +2 V +2 Easy +2 −0 updated 04/04/17, 06:41

Commit message

CKEditor should allow data attributes and class attribute by
default, otherwise any link added in the typolink popup
will get removed automatically by CKEditor's Content filter.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Jan Helke +1
    • Frans Saris +1
  • Verified V +2
    • Andreas Kienast +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Benni Mack uploaded patch set 1 04/04/17, 05:25

  2. Thomas Hohn voted on patch set 1 CR +1 04/04/17, 05:33

  3. TYPO3com voted on patch set 1 V +1 04/04/17, 05:35 Completed build in 10m 02s on Tue, 4 Apr, 07:35 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10267

  4. Georg Ringer voted on patch set 1 CR +1 V +1 04/04/17, 05:39

  5. Susi Moog voted on patch set 1 CR +1 04/04/17, 06:00

  6. Frans Saris commented on patch set 1 04/04/17, 06:03

    Base.yaml:10

    any class or any attribute?
  7. Wouter Wolters voted on patch set 1 CR +1 04/04/17, 06:05

  8. Benni Mack commented on patch set 2 04/04/17, 06:07

    Published edit on patch set 1.
  9. Frans Saris voted on patch set 2 CR +1 04/04/17, 06:12

  10. Wouter Wolters voted on patch set 2 CR +1 04/04/17, 06:13

  11. TYPO3com voted on patch set 2 V +1 04/04/17, 06:15 Completed build in 07m 22s on Tue, 4 Apr, 08:15 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10269

  12. Andreas Kienast voted on patch set 2 CR +1 04/04/17, 06:18

  13. Jan Helke voted on patch set 2 CR +1 V +1 04/04/17, 06:41

  14. Andreas Kienast voted on patch set 2 V +1 04/04/17, 06:41

  15. Andreas Kienast voted on patch set 2 CR +2 V +2 04/04/17, 06:41

  16. Gerrit merged patch set 2 04/04/17, 06:41