52351[BUGFIX] Creating typolink in backend should not throw an exception
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Frans Saris +1
- Oliver Hader +1
-
Verified V +2
- Benni Mack +2
- Frans Saris +1
- Mona Muzaffar +1
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1719
-
Benni Mack uploaded patch set 1 04/04/17, 06:40
-
TYPO3com voted on patch set 1 V +1 04/04/17, 06:48 Completed build in 07m 56s on Tue, 4 Apr, 08:48 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10271
-
Thomas Hohn voted on patch set 1 CR +1 04/04/17, 06:50
-
Susi Moog voted on patch set 1 CR +1 04/04/17, 06:54
-
Frans Saris voted on patch set 1 CR +1 04/04/17, 06:55
-
Susi Moog voted on patch set 1 V +1 04/04/17, 06:57
-
Oliver Hader commented on patch set 1 CR +1 04/04/17, 07:32
This might have side-effects concerning the injected ID via GetPost or cross-domain linking... for a basic URL generation it should be enough however -
Frans Saris commented on patch set 1 04/04/17, 07:38
<f:link.typolink parameter="http://www.typo3.com">test</f:link.typolink> goes ok, but <f:link.typolink parameter="3">test</f:link.typolink> gives me an exception not sure if the second is supported? Call to a member function linkData() on null Error thrown in file /var/www/master/typo3_src-git/typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php in line 194. 45 TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build(array, "test", "", array) -
Mona Muzaffar voted on patch set 1 V +1 04/04/17, 07:42
-
Benni Mack voted on patch set 1 CR +2 V +2 04/04/17, 07:45
-
Benni Mack voted on patch set 1 CR -2 04/04/17, 07:46
-
Benni Mack uploaded patch set 2 04/04/17, 07:48
-
Frans Saris voted on patch set 2 CR +1 V +1 04/04/17, 07:50
-
Oliver Hader commented on patch set 2 CR +1 V +1 04/04/17, 07:54
Thx, works now with tmpl->linkData -
Benni Mack commented on patch set 2 CR 0 04/04/17, 07:56
waiting for travis -
TYPO3com voted on patch set 2 V +1 04/04/17, 07:56 Completed build in 08m 27s on Tue, 4 Apr, 09:56 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10276
-
Mona Muzaffar voted on patch set 2 V +1 04/04/17, 08:01
-
Benni Mack voted on patch set 2 CR +2 V +2 04/04/17, 08:01
-
Gerrit merged patch set 2 04/04/17, 08:01