Review main Merged

52362[BUGFIX] Do not use doctrine constraints without bind values

Christer V CR +2 V +2 Easy +19 −6 updated 04/06/17, 05:16

Commit message

Changed so doctrine constraints without the corresponding
bind values aren't passed around.

The $constraints variable defined in CleanerTask->cleanTable
is reused in CleanerTask->deleteFilesForTable, but without
the doctrine createNamedParameter bind variables, since the
querybuilder is recreated. This caused the task to fail.

Review

  • Code review CR +2
    • Markus Klein +2
    • Thomas Hohn +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Christer V uploaded patch set 1 04/04/17, 11:00

  2. TYPO3com voted on patch set 1 V +1 04/04/17, 11:09 Completed build in 08m 42s on Tue, 4 Apr, 01:09 PM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10294

  3. Thomas Hohn voted on patch set 1 CR +1 04/04/17, 11:17

  4. Markus Klein commented on patch set 1 CR -1 04/04/17, 11:35

    this is a bug report title and not a commit message title. please describe what is being changed!
    this has to go into the ticket!
  5. Christer V updated the commit message in patch set 2 04/04/17, 11:59

  6. TYPO3com voted on patch set 2 V +1 04/04/17, 12:07 Completed build in 08m 01s on Tue, 4 Apr, 02:07 PM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10296

  7. Thomas Hohn voted on patch set 2 CR +1 04/05/17, 06:15

  8. Markus Klein voted on patch set 2 CR +1 04/05/17, 07:19

  9. Frank Nägler commented on patch set 2 CR -1 04/05/17, 07:34

    CleanerTask.php:172

    breaking change, class could be extended

    CleanerTask.php:187

    breaking change, class could be extended. remove a parameter in the middle without deprecation is not possible
  10. Markus Klein commented on patch set 2 04/05/17, 07:36

    CleanerTask.php:172 Reply

    we never treated protected methods as API
  11. Frank Nägler commented on patch set 2 CR 0 04/05/17, 08:01

    after a short talk with Markus I remove my -1
  12. Wouter Wolters voted on patch set 2 CR +1 04/05/17, 13:44

  13. Wouter Wolters voted on patch set 2 V +1 04/05/17, 18:10

  14. Markus Klein voted on patch set 2 CR +2 V +2 04/06/17, 05:15

  15. Gerrit merged patch set 2 04/06/17, 05:16