52362[BUGFIX] Do not use doctrine constraints without bind values
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Thomas Hohn +1
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1315
-
Christer V uploaded patch set 1 04/04/17, 11:00
-
TYPO3com voted on patch set 1 V +1 04/04/17, 11:09 Completed build in 08m 42s on Tue, 4 Apr, 01:09 PM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10294
-
Thomas Hohn voted on patch set 1 CR +1 04/04/17, 11:17
-
Markus Klein commented on patch set 1 CR -1 04/04/17, 11:35
this is a bug report title and not a commit message title. please describe what is being changed!this has to go into the ticket! -
Christer V updated the commit message in patch set 2 04/04/17, 11:59
-
TYPO3com voted on patch set 2 V +1 04/04/17, 12:07 Completed build in 08m 01s on Tue, 4 Apr, 02:07 PM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10296
-
Thomas Hohn voted on patch set 2 CR +1 04/05/17, 06:15
-
Markus Klein voted on patch set 2 CR +1 04/05/17, 07:19
-
Frank Nägler commented on patch set 2 CR -1 04/05/17, 07:34
CleanerTask.php:172breaking change, class could be extendedCleanerTask.php:187breaking change, class could be extended. remove a parameter in the middle without deprecation is not possible -
Markus Klein commented on patch set 2 04/05/17, 07:36
CleanerTask.php:172Replywe never treated protected methods as API -
Frank Nägler commented on patch set 2 CR 0 04/05/17, 08:01
after a short talk with Markus I remove my -1 -
Wouter Wolters voted on patch set 2 CR +1 04/05/17, 13:44
-
Wouter Wolters voted on patch set 2 V +1 04/05/17, 18:10
-
Markus Klein voted on patch set 2 CR +2 V +2 04/06/17, 05:15
-
Gerrit merged patch set 2 04/06/17, 05:16