Review main Merged

52364[BUGFIX] Adapt fluid_styled_content paths in initial page

Helmut Hummel CR +2 V +2 Easy +2 −2 updated 04/05/17, 09:25

Commit message

When installing TYPO3 with the option to create a page with
TypoScript template, the template does not match the latest
state of fluid_styled_content.

Adapt path and reference the content rendering instead of copying it.

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Helmut Hummel uploaded patch set 1 04/05/17, 07:47

  2. Benni Mack updated the commit message in patch set 2 04/05/17, 07:51

  3. Benni Mack commented on patch set 2 CR +1 04/05/17, 07:51

    Great, thanks. that was the one part I wanted to test yesterday, but did not. Thanks for the fix!
  4. Benjamin Kott voted on patch set 2 CR +1 04/05/17, 07:52

  5. Andreas Kienast voted on patch set 2 CR +1 04/05/17, 07:52

  6. TYPO3com voted on patch set 1 V +1 04/05/17, 07:55 Completed build in 07m 53s on Wed, 5 Apr, 09:55 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10302

  7. TYPO3com voted on patch set 2 V +1 04/05/17, 08:00 Completed build in 08m 54s on Wed, 5 Apr, 10:00 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10303

  8. Benni Mack updated the commit message in patch set 3 04/05/17, 08:03

  9. Benni Mack commented on patch set 3 CR +1 V +1 04/05/17, 08:03

    Fixed another typo in the commit message. Works just fine!
  10. Markus Klein commented on patch set 3 04/05/17, 08:10

    DefaultConfiguration.php:101

    why the reference?
  11. TYPO3com voted on patch set 3 V +1 04/05/17, 08:12 Completed build in 08m 51s on Wed, 5 Apr, 10:12 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10304

  12. Helmut Hummel commented on patch set 3 04/05/17, 08:53

    DefaultConfiguration.php:101 Reply

    In this case it does not matter much But I learned that referencing is the correct way to use styles.content.get because not referencing could break depending on how it was set up. always referencing it resolves such issues
  13. Markus Klein commented on patch set 3 CR +2 V +2 04/05/17, 09:25

    DefaultConfiguration.php:101 Reply

    unless you want to unset something that is defined in the referenced TS.
  14. Gerrit merged patch set 3 04/05/17, 09:25