Review main Abandoned

52368[TASK] Add quicktime mime type to VideoTagRenderer

Daniel Dorndorf CR 0 V 0 Easy +1 −1 updated 04/06/17, 07:47

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. Daniel Dorndorf uploaded patch set 1 04/05/17, 17:47

  2. Markus Klein commented on patch set 1 04/05/17, 17:49

    As we discussed in the thread on Slack: I'm not sure why quicktime shows up at all. Can you please provide us a sample where this is really necessary?
  3. Markus Klein commented on patch set 1 CR -1 04/05/17, 17:51

    putting a minor -1 on this one until the ticket is filled with more info an how to reproduce that.
  4. TYPO3com voted on patch set 1 V +1 04/05/17, 17:57 Completed build in 09m 44s on Wed, 5 Apr, 07:57 PM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10318

  5. Frans Saris commented on patch set 1 04/05/17, 18:16

    If it's a valid mimetype to support this should also go in 7.6 But it's not a global accepted web standard https://www.w3schools.com/tags/tag_video.asp
  6. Daniel Dorndorf commented on patch set 1 CR +1 V +1 04/05/17, 18:22

    > If it's a valid mimetype to support this should also go in 7.6 > > But it's not a global accepted web standard https://www.w3schools.com/tags/tag_video.asp I've had trouble with a mp4 file having the mime type "video/quicktime" but all browsers were able to play it, windows/linux etc. tested
  7. Markus Klein commented on patch set 1 04/06/17, 06:26

    1.) Please do not vote for your own patches 2.) The information I got about your video file from VLC is that it is actually a correct normal mp4 file, not a quicktime one. 3.) It looks like your server is reporting a wrong mimetype to TYPO3. Please figure that out first.
  8. Daniel Dorndorf commented on patch set 1 CR 0 V 0 04/06/17, 07:10

    1.) Sorry I didn't knew 2.) Which file do you mean? 3.) TYPO3 or PHP interprets "video/quicktime" for my mp4 file, I'll make some debugging and testing. I think this commit was a bit hastly for now, will have to investigate this more deeply. Can we close or reject this?
  9. Mathias Brodala commented on patch set 1 04/06/17, 07:17

    > Can we close or reject this? You can hit the Abandon button here.
  10. Daniel Dorndorf abandoned the change 04/06/17, 07:47

    Missing mime type isn't the issue. Maybe corrupt file or missinterpreted mime type