Review main Merged

52379[BUGIFX] Allow file replace for editors

Helmut Hummel CR +2 V +2 Easy +0 −3 updated 04/07/17, 14:39

Commit message

When file extension permissions are configured, replacing
a file fails with an error message, because the file extension
is checked on the local path of the temporary file.

Remove this bogus check to allow file replace for editors.

Review

  • Code review CR +2
    • Markus Klein +2
    • Thomas Hohn +1
    • Frans Saris +1
  • Verified V +2
    • Markus Klein +2
    • Riccardo De Contardi +1
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Helmut Hummel uploaded patch set 1 04/06/17, 19:07

  2. Helmut Hummel commented on patch set 1 04/06/17, 19:12

    I thinks this qualifies for 6.2 backport, but I'm also fine with 7.6 and master only
  3. Helmut Hummel commented on patch set 1 04/06/17, 19:14

    Please look at the forge ticket for more detailed description how to reproduce
  4. TYPO3com voted on patch set 1 V +1 04/06/17, 19:18 Completed build in 10m 16s on Thu, 6 Apr, 09:18 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10347

  5. Wouter Wolters commented on patch set 1 04/06/17, 19:22

    Remove this bogus check
  6. Helmut Hummel updated the commit message in patch set 2 04/06/17, 20:06

  7. TYPO3com voted on patch set 2 V +1 04/06/17, 20:14 Completed build in 08m 15s on Thu, 6 Apr, 10:14 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10349

  8. Riccardo De Contardi voted on patch set 2 V +1 04/06/17, 20:21

  9. Thomas Hohn voted on patch set 2 CR +1 04/06/17, 20:22

  10. Frans Saris voted on patch set 2 CR +1 04/07/17, 13:56

  11. Frans Saris voted on patch set 2 V +1 04/07/17, 14:01

  12. Markus Klein voted on patch set 2 CR +2 V +2 04/07/17, 14:37

  13. Gerrit merged patch set 2 04/07/17, 14:37

  14. Markus Klein commented on patch set 3 04/07/17, 14:38

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit ac4471dc14efd21194cea9be4beee296024b1660
  15. Markus Klein commented on patch set 3 04/07/17, 14:39

    gnaaa... nobody (incl. me) spotted the boogiiiifix.