Review main Merged

52380[BUGFIX] Do not prefix FAL file links with absRefPrefix

Helmut Hummel CR +2 V +2 Easy +5 −1 updated 04/26/17, 15:12

Commit message

When using an external FAL storage the public URLs of files contain a scheme.
Check for the scheme before prefixing with absRefPrefix
in file link builder.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Manuel Selbach +1
    • Frans Saris +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Helmut Hummel uploaded patch set 1 04/06/17, 20:32

  2. TYPO3com voted on patch set 1 V +1 04/06/17, 20:42 Completed build in 10m 04s on Thu, 6 Apr, 10:42 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10350

  3. Markus Klein commented on patch set 1 04/06/17, 21:04

    don't we have similar code in 7 as well?
  4. Helmut Hummel updated the commit message in patch set 2 04/06/17, 21:09

  5. Helmut Hummel commented on patch set 2 04/06/17, 21:09

    Indeed. Seems nobody is really using external FAL storages ^^
  6. TYPO3com voted on patch set 2 V +1 04/06/17, 21:18 Completed build in 09m 06s on Thu, 6 Apr, 11:18 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10351

  7. Markus Klein commented on patch set 2 04/06/17, 21:43

    We do soon on large scale, but for now the hassle with local ones is already enough ^^
  8. Markus Klein commented on patch set 2 CR +1 V +1 04/06/17, 21:43

    giving v+1 too, since local links still work ;-)
  9. Frans Saris voted on patch set 2 CR +1 04/07/17, 06:15

  10. Wouter Wolters voted on patch set 2 CR +1 04/10/17, 21:05

  11. Manuel Selbach voted on patch set 2 CR +1 V +1 04/11/17, 09:14

  12. Helmut Hummel voted on patch set 2 CR +2 V +2 04/11/17, 09:20

  13. Gerrit merged patch set 2 04/11/17, 09:21

  14. Stephan Großberndt commented on patch set 3 04/25/17, 09:23

    Backport to 7.6 is missing
  15. Markus Klein commented on patch set 3 04/26/17, 15:12

    Prepared the backport, please check https://review.typo3.org/52615