Review main Abandoned

52383[TASK] Add dependency postcss-scss for Grunt

Markus Sommer CR 0 V 0 Easy +1 −0 updated 04/07/17, 10:59

Commit message

This dependency is definined in the Gruntfile but not in the package.json

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Markus Sommer uploaded patch set 1 04/07/17, 09:28

  2. Markus Sommer updated the commit message in patch set 2 04/07/17, 09:29

  3. TYPO3com voted on patch set 1 V +1 04/07/17, 09:36 Completed build in 08m 06s on Fri, 7 Apr, 11:36 AM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10363

  4. TYPO3com voted on patch set 2 V +1 04/07/17, 09:42 Completed build in 13m 10s on Fri, 7 Apr, 11:42 AM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10364

  5. Elmar Hinz voted on patch set 2 CR +1 04/07/17, 10:37

  6. Benjamin Kott commented on patch set 2 CR -2 04/07/17, 10:41

    no need for this dependency, postcss-sass is a dependency of stylefmt and is only required in context of this
  7. Markus Sommer abandoned the change 04/07/17, 10:59

    it is only used in the stylefmt context. so wie can use the deep requirement of the parent package