Review main Merged

52385[TASK] Resolve grunt build errors

Markus Sommer CR +2 V +2 Expert +146 −863 updated 04/19/17, 17:06

Commit message

* Remove /* @end */ comments
* Add missing line end line
* Remove unnessasery blank lines
* Add chosen to git

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Henrik Elsner +1
  • Verified V +2
    • Wouter Wolters +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1520

  1. Markus Sommer uploaded patch set 1 04/07/17, 11:59

  2. TYPO3com voted on patch set 1 V +1 04/07/17, 12:10 Completed build in 10m 22s on Fri, 7 Apr, 02:10 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10366

  3. Henrik Elsner uploaded patch set 2 04/10/17, 13:36

  4. TYPO3com voted on patch set 2 V +1 04/10/17, 13:43 Completed build in 07m 28s on Mon, 10 Apr, 03:43 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10439

  5. Henrik Elsner uploaded patch set 3 04/10/17, 15:19

  6. TYPO3com voted on patch set 3 V +1 04/10/17, 15:25 Completed build in 06m 17s on Mon, 10 Apr, 05:25 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10443

  7. Wouter Wolters voted on patch set 3 CR +1 04/10/17, 20:44

  8. Henrik Elsner voted on patch set 3 CR +1 V +1 04/11/17, 07:13

  9. Thomas Hohn voted on patch set 3 CR +1 04/18/17, 12:31

  10. Wouter Wolters commented on patch set 3 CR 0 04/19/17, 09:24

    Can chosen be minified?
  11. Henrik Elsner commented on patch set 3 V -1 04/19/17, 09:29

    @Wouter what do you mean ? Actually just noticed the file is named wrong
  12. Henrik Elsner uploaded patch set 4 04/19/17, 10:18

  13. TYPO3com voted on patch set 4 V +1 04/19/17, 10:26 Completed build in 08m 29s on Wed, 19 Apr, 12:26 PM Test Summary: 56204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10701

  14. Henrik Elsner voted on patch set 4 CR +1 V +1 04/19/17, 12:18

  15. Henrik Elsner uploaded patch set 5 04/19/17, 12:30

  16. TYPO3com voted on patch set 5 V +1 04/19/17, 12:41 Completed build in 10m 25s on Wed, 19 Apr, 02:41 PM Test Summary: 56204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10709

  17. Wouter Wolters voted on patch set 5 CR +1 V +1 04/19/17, 13:33

  18. Henrik Elsner voted on patch set 5 CR +1 V +1 04/19/17, 13:42

  19. Wouter Wolters voted on patch set 5 CR +2 V +2 04/19/17, 17:06

  20. Gerrit merged patch set 5 04/19/17, 17:06