Review TYPO3_7-6 Merged

52386[BUGFIX] DBAL: Assure all optional query array parameters are set

Dan Kleine - geb. Untenzu CR +2 V +2 Easy +16 −1 updated 05/18/17, 13:28

Commit message

The method »exec_SELECT_queryArray« uses an incoming array and
passes all possible query array keys on to the »exec_SELECTquery« method.
If not all keys were set, then »NULL« is passed. It should pass an
empty string however.

To avoid exceptions thrown due to NULL values, the method
now provides a fallback for all optional array keys.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Dan Kleine - geb. Untenzu uploaded patch set 1 04/07/17, 13:17

  2. TYPO3com voted on patch set 1 V +1 04/07/17, 13:23 Completed build in 05m 05s on Fri, 7 Apr, 03:23 PM Test Summary: 38607 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-881

  3. Morton Jonuschat commented on patch set 1 CR -1 04/08/17, 04:28

    DatabaseConnection.php:370

    WHERE should be added as well. `SELECT aField FROM aTable` is a valid query after all.
  4. Dan Kleine - geb. Untenzu commented on patch set 1 04/11/17, 08:14

    DatabaseConnection.php:370 Reply

    Since this method effectively is just another way to pass parameters to »exec_SELECTquery«, which requires »WHERE«, I ignored this intentionally.
  5. Dan Kleine - geb. Untenzu uploaded patch set 2 05/17/17, 08:17

  6. TYPO3com voted on patch set 2 V +1 05/17/17, 08:23 Completed build in 05m 46s on Wed, 17 May, 10:23 AM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-936

  7. Wouter Wolters updated the commit message in patch set 3 05/17/17, 08:45

  8. Wouter Wolters commented on patch set 3 05/17/17, 08:45

    removed 6.2 from the releases line. 6.2 is not supported anymore by the core team.
  9. TYPO3com voted on patch set 3 V +1 05/17/17, 08:50 Completed build in 05m 08s on Wed, 17 May, 10:50 AM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-938

  10. Jan Helke voted on patch set 3 CR +1 V +1 05/18/17, 13:25

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 05/18/17, 13:27

  12. Gerrit merged patch set 3 05/18/17, 13:28