52435[BUGFIX] Fix bug due to improper usage of boolean as object
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Manuel Selbach +1
- Morton Jonuschat +1
-
Verified V +2
- Christian Kuhn +2
- Morton Jonuschat +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1319
-
Sven Carstens uploaded patch set 1 04/13/17, 06:42
-
Wouter Wolters updated the commit message in patch set 2 04/13/17, 06:46
-
Wouter Wolters commented on patch set 2 04/13/17, 06:47
Thanks for the patch, I added the missing Releases line to the commit message. -
TYPO3com voted on patch set 1 V +1 04/13/17, 06:49 Completed build in 06m 42s on Thu, 13 Apr, 08:49 AM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10506
-
TYPO3com voted on patch set 2 V +1 04/13/17, 06:53 Completed build in 06m 17s on Thu, 13 Apr, 08:53 AM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10507
-
Manuel Selbach voted on patch set 2 CR +1 04/13/17, 07:05
-
Benni Mack commented on patch set 3 04/13/17, 08:10
Published edit on patch set 2. -
Benni Mack commented on patch set 4 04/13/17, 08:10
Published edit on patch set 3. -
Benni Mack voted on patch set 4 CR +1 04/13/17, 08:11
-
TYPO3com voted on patch set 3 V +1 04/13/17, 08:20 Completed build in 10m 12s on Thu, 13 Apr, 10:20 AM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10509
-
TYPO3com voted on patch set 4 V -1 04/13/17, 08:20 Completed build in 09m 41s on Thu, 13 Apr, 10:20 AM Test Summary: 47568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10510
-
TYPO3com commented on patch set 4 04/13/17, 21:45 Completed build in 13h 44m 02s on Thu, 13 Apr, 11:45 PM Test Summary: 47568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10510
-
Wouter Wolters rebased onto patch set 5 04/14/17, 09:24
-
TYPO3com voted on patch set 5 V +1 04/14/17, 09:34 Completed build in 10m 20s on Fri, 14 Apr, 11:34 AM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10529
-
Manuel Selbach voted on patch set 5 CR +1 04/14/17, 10:30
-
Wouter Wolters voted on patch set 5 CR +1 04/14/17, 12:09
-
Morton Jonuschat commented on patch set 5 CR +1 V +1 04/15/17, 17:30
Looks good. I would prefer that we add a functional test around this, but wont block this on a new test. -
Christian Kuhn voted on patch set 5 CR +2 V +2 04/16/17, 20:07
-
Gerrit merged patch set 5 04/16/17, 20:07