Review main Merged

52437[TASK] Update comments in ExtensionManagementUtility

Jigal van Hemert CR +2 V +2 Easy +10 −6 updated 04/27/17, 11:29

Commit message

Comments now mention that functions in ExtensionManagementUtility
must not be used in ext_tables.php

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Jigal van Hemert uploaded patch set 1 04/13/17, 13:44

  2. TYPO3com voted on patch set 1 V +1 04/13/17, 13:53 Completed build in 09m 09s on Thu, 13 Apr, 03:53 PM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10514

  3. Thomas Hohn commented on patch set 1 04/13/17, 20:11

    ExtensionManagementUtility.php:259

    Maybe write Used or Usage in?

    ExtensionManagementUtility.php:278

    Maybe write Used or Usage in?
  4. Benni Mack commented on patch set 1 04/27/17, 09:17

    How about we backport that to 8.7 as well? Seems valid to me as it is a "bug" in comments for me.
  5. Thomas Hohn updated the commit message in patch set 2 04/27/17, 11:04

  6. TYPO3com voted on patch set 2 V +1 04/27/17, 11:12 Completed build in 08m 20s on Thu, 27 Apr, 01:12 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11029

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 04/27/17, 11:18

  8. Benni Mack voted on patch set 2 CR +2 V +2 04/27/17, 11:29

  9. Gerrit merged patch set 2 04/27/17, 11:29

  10. Benni Mack commented on patch set 3 04/27/17, 11:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3f8d3bda38827eecea3f1656dceb751fe67fe224