Review main Abandoned

52455[FEATURE] Add VIEWHELPER content object type

Claus Due CR 0 V 0 Normal +115 −0 updated 02/11/18, 00:55

Commit message

Allows calling a single ViewHelper with desired arguments,
tag content, template variables and namespaces for resolving.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1623

  1. Claus Due uploaded patch set 1 04/14/17, 20:19

  2. Claus Due uploaded patch set 2 04/14/17, 20:22

  3. Claus Due uploaded patch set 3 04/14/17, 20:26

  4. TYPO3com voted on patch set 1 V -1 04/14/17, 20:28 Completed build in 08m 21s on Fri, 14 Apr, 10:28 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10573

  5. TYPO3com voted on patch set 2 V -1 04/14/17, 20:32 Completed build in 09m 13s on Fri, 14 Apr, 10:32 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10574

  6. TYPO3com voted on patch set 3 V -1 04/14/17, 20:42 Completed build in 16m 07s on Fri, 14 Apr, 10:42 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10576

  7. Claus Due uploaded patch set 4 04/14/17, 20:59

  8. TYPO3com voted on patch set 4 V -1 04/14/17, 21:08 Completed build in 09m 01s on Fri, 14 Apr, 11:08 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10577

  9. Claus Due commented on patch set 5 05/05/17, 02:00

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V -1 05/05/17, 02:05 Completed build in 05m 04s on Fri, 5 May, 04:05 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11211

  11. Claus Due commented on patch set 6 05/05/17, 02:07

    Published edit on patch set 5.
  12. TYPO3com voted on patch set 6 V -1 05/05/17, 02:12 Completed build in 05m 21s on Fri, 5 May, 04:12 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11212

  13. Jan Helke uploaded patch set 7 05/05/17, 14:33

  14. TYPO3com voted on patch set 7 V +1 05/05/17, 14:38 Completed build in 05m 29s on Fri, 5 May, 04:38 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11231

  15. Oliver Klee commented on patch set 7 05/05/17, 14:54

    ViewHelperContentObject.php:1

    Can we please have strict mode and all type hints?

    ViewHelperContentObject.php:24

    Can we please have documentation and unit tests for the new class?

    ext_localconf.php:32

    The indentation here is inconsistent to the other array elements (there are 3 spaces missing).
  16. Benni Mack commented on patch set 7 CR -1 12/09/17, 21:22

    I don't see why we should add this to the Core, as I don't see the benefit of bringing back Fluid into TypoScript here...
  17. Claus Due commented on patch set 7 12/11/17, 10:46

    > I don't see why we should add this to the Core, as I don't see the benefit of bringing back Fluid into TypoScript here... The idea is to make it possible to use an existing ViewHelper instead of writing a new DataProcessor. In the very long term it would make DataProcessors redundant (because we can have it done by ViewHelpers and so useful in both TS and Fluid). It's a paradigm shift, sure, but I see extreme similarities between DataProcessors and ViewHelpers and IMHO they should be the same thing (where I'd choose ViewHelpers because they also work in Fluid).
  18. Mathias Schreiber commented on patch set 7 02/05/18, 21:34

    > Patch Set 7: > > > I don't see why we should add this to the Core, as I don't see the benefit of bringing back Fluid into TypoScript here... > > The idea is to make it possible to use an existing ViewHelper instead of writing a new DataProcessor. In the very long term it would make DataProcessors redundant (because we can have it done by ViewHelpers and so useful in both TS and Fluid). can you provide a quick snippet how this would look like in action? Plus all the Dataprocessors we use fetch data in one way or another. I am not fond of Viewhelpers that fetch data from places :D
  19. Claus Due commented on patch set 7 02/06/18, 11:17

    > can you provide a quick snippet how this would look like in action? Sure, but it's a freestyle quick version ;) xyz = VIEWHELPER xyz { name = f:link.action arguments { pageUid = {$my.constant.targetPageUid} action = list extensionName = News pluginName = pi_news } } Benefits are, you can reference the ViewHelper by namespace and VH name, meaning it also respects the system-configured overlays for namespaces. And it triggers completely identical rendering compared to using it in a template; including when the VH is a tag-based VH which comes with several other useful features when generating tags (ignore-empty, pass data array, for example). The discussion about fetching data in the view is a bit off-topic here (but I am happy to have it, of course!). This patch does the opposite: allows you to use previously View-context-only features from TS.
  20. Oliver Hader commented on patch set 7 CR -1 02/07/18, 09:16

    Since this mixes concerns and violates the basic MVC patterns we have, I'd suggest to not include this change. DataProcessors and ViewHelpers have different scopes in terms of when and for what they are used. Hand-crafting the rendering context is a good indicator that this is hacky... sorry
  21. Tymoteusz Motylewski commented on patch set 7 02/07/18, 16:01

    Before we add yet another way to render stuff, I would like to understand whatis the root issue we're trying to solve. I'm not really sure what are the benefits for integrators or developers. Will it be easier to integrators to templates to TYPO3? Maybe there is a different solution for the problem?
  22. Benni Mack abandoned the change 02/11/18, 00:07

    Abandoned for the mentioned reasons. Really sorry Claus, but it's still possible to do this as an extension if needed.
  23. Claus Due commented on patch set 7 02/11/18, 00:55

    No worries, Benni. You are completely right - it is very easy to create such things as extensions.