Review main Abandoned

52461[FEATURE] Add a rootline class, improve rootline repository

Elmar Hinz CR 0 V 0 Nightmare +4587 −728 updated 06/10/18, 19:07

Commit message

Improve RootlineUtility
-----------------------

- Give it a more prominent place. A caching loader is not just an utility.
- Move code around. Separate into functional units.
- Break up large functions into testable units.
- 100% test coverage, apart from RootLineRelationsLoader.
- Lowering max. CRAP index from 1081 to 274.
- Replace static caches by the caching framework runtime cache.
- Introduce a root line identiy object to bundle context parameters.
- Provide a root line class, to bundle rootline data and functionality.
- More finegrained exceptions.
- Migrate all existing unit tests.
- Apply as dropin-replacement for RootlineUtility::get().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 22

Show 2 more files

Review log 132252

Show 118227 earlier messages
  1. Elmar Hinz uploaded patch set 1 04/16/17, 09:47

  2. TYPO3com voted on patch set 1 V -1 04/16/17, 09:51 Completed build in 04m 08s on Sun, 16 Apr, 11:51 AM Test Summary: 928 of 1077 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-209

  3. TYPO3com commented on patch set 1 04/16/17, 09:57 Completed build in 10m 26s on Sun, 16 Apr, 11:57 AM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10598

  4. Frans Saris commented on patch set 1 04/16/17, 10:14

    A utility class shouldn't have state. And every method should get all needed values as parameters. Don't think this class suits to be a utility class
  5. Elmar Hinz commented on patch set 1 04/16/17, 10:17

    @Frans Saris: Right an utility class should not have state. That's one reason to this.
  6. Elmar Hinz uploaded patch set 2 04/16/17, 10:52

  7. TYPO3com voted on patch set 2 V -1 04/16/17, 10:56 Completed build in 04m 16s on Sun, 16 Apr, 12:56 PM Test Summary: 928 of 1077 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-210

  8. TYPO3com commented on patch set 2 04/16/17, 10:59 Completed build in 06m 54s on Sun, 16 Apr, 12:59 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10599

  9. Elmar Hinz uploaded patch set 3 04/16/17, 12:19

  10. TYPO3com voted on patch set 3 V -1 04/16/17, 12:27 Completed build in 07m 55s on Sun, 16 Apr, 02:27 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10600

  11. Elmar Hinz uploaded patch set 4 04/16/17, 12:33

  12. TYPO3com voted on patch set 4 V +1 04/16/17, 12:42 Completed build in 08m 51s on Sun, 16 Apr, 02:42 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10602

  13. Elmar Hinz uploaded patch set 5 04/16/17, 13:59

  14. TYPO3com voted on patch set 5 V +1 04/16/17, 14:07 Completed build in 08m 12s on Sun, 16 Apr, 04:07 PM Test Summary: 56630 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10603

  15. Elmar Hinz uploaded patch set 6 04/16/17, 14:22

  16. Elmar Hinz uploaded patch set 7 04/16/17, 14:25

  17. TYPO3com voted on patch set 6 V +1 04/16/17, 14:30 Completed build in 08m 31s on Sun, 16 Apr, 04:30 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10605

  18. TYPO3com voted on patch set 7 V +1 04/16/17, 14:35 Completed build in 09m 55s on Sun, 16 Apr, 04:35 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10606

  19. Elmar Hinz uploaded patch set 8 04/16/17, 14:53

  20. TYPO3com voted on patch set 8 V +1 04/16/17, 15:07 Completed build in 14m 12s on Sun, 16 Apr, 05:07 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10609

  21. Elmar Hinz uploaded patch set 9 04/16/17, 17:12

  22. Elmar Hinz uploaded patch set 10 04/16/17, 17:15

  23. TYPO3com voted on patch set 9 V +1 04/16/17, 17:19 Completed build in 07m 17s on Sun, 16 Apr, 07:19 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10611

  24. TYPO3com voted on patch set 10 V +1 04/16/17, 17:25 Completed build in 09m 33s on Sun, 16 Apr, 07:25 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10612

  25. Oliver Klee commented on patch set 10 04/16/17, 18:06

    RootLineFetcher.php:44

    possibly: to -> not
  26. Elmar Hinz uploaded patch set 11 04/16/17, 19:15

  27. Elmar Hinz commented on patch set 10 04/16/17, 19:16

    RootLineFetcher.php:44 Reply

    Done
  28. TYPO3com voted on patch set 11 V -1 04/16/17, 19:24 Completed build in 08m 55s on Sun, 16 Apr, 09:24 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10613

  29. Elmar Hinz uploaded patch set 12 04/16/17, 19:26

  30. TYPO3com voted on patch set 12 V -1 04/16/17, 19:33 Completed build in 06m 24s on Sun, 16 Apr, 09:33 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10614

  31. Elmar Hinz uploaded patch set 13 04/16/17, 19:45

  32. Elmar Hinz uploaded patch set 14 04/16/17, 19:51

  33. TYPO3com voted on patch set 13 V -1 04/16/17, 19:54 Completed build in 09m 17s on Sun, 16 Apr, 09:54 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10615

  34. TYPO3com voted on patch set 14 V -1 04/16/17, 20:01 Completed build in 09m 37s on Sun, 16 Apr, 10:01 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10616

  35. Elmar Hinz uploaded patch set 15 04/17/17, 11:05

  36. TYPO3com voted on patch set 15 V -1 04/17/17, 11:12 Completed build in 07m 05s on Mon, 17 Apr, 01:12 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10621

  37. Elmar Hinz uploaded patch set 16 04/17/17, 11:50

  38. TYPO3com voted on patch set 16 V -1 04/17/17, 11:58 Completed build in 07m 40s on Mon, 17 Apr, 01:58 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10623

  39. Elmar Hinz uploaded patch set 17 04/17/17, 14:27

  40. TYPO3com voted on patch set 17 V -1 04/17/17, 14:35 Completed build in 07m 31s on Mon, 17 Apr, 04:35 PM Test Summary: 1 of 56645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10624

  41. Elmar Hinz uploaded patch set 18 04/17/17, 14:51

  42. TYPO3com voted on patch set 18 V -1 04/17/17, 15:00 Completed build in 09m 19s on Mon, 17 Apr, 05:00 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10625

  43. Elmar Hinz uploaded patch set 19 04/17/17, 15:04

  44. TYPO3com voted on patch set 19 V +1 04/17/17, 15:13 Completed build in 08m 17s on Mon, 17 Apr, 05:13 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10626

  45. Elmar Hinz uploaded patch set 20 04/17/17, 17:04

  46. TYPO3com voted on patch set 20 V +1 04/17/17, 17:15 Completed build in 10m 52s on Mon, 17 Apr, 07:15 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10628

  47. Elmar Hinz uploaded patch set 21 04/17/17, 18:00

  48. Elmar Hinz uploaded patch set 22 04/17/17, 18:01

  49. TYPO3com voted on patch set 21 V -1 04/17/17, 18:09 Completed build in 09m 09s on Mon, 17 Apr, 08:09 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10630

  50. TYPO3com voted on patch set 22 V +1 04/17/17, 18:13 Completed build in 12m 37s on Mon, 17 Apr, 08:13 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10631

  51. Elmar Hinz uploaded patch set 23 04/17/17, 18:38

  52. TYPO3com voted on patch set 23 V +1 04/17/17, 18:49 Completed build in 10m 30s on Mon, 17 Apr, 08:49 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10632

  53. Elmar Hinz uploaded patch set 24 04/17/17, 18:52

  54. TYPO3com voted on patch set 24 V +1 04/17/17, 19:04 Completed build in 10m 59s on Mon, 17 Apr, 09:04 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10633

  55. Elmar Hinz uploaded patch set 25 04/17/17, 19:41

  56. TYPO3com voted on patch set 25 V +1 04/17/17, 19:53 Completed build in 12m 09s on Mon, 17 Apr, 09:53 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10634

  57. Elmar Hinz uploaded patch set 26 04/17/17, 20:05

  58. TYPO3com voted on patch set 26 V +1 04/17/17, 20:15 Completed build in 09m 33s on Mon, 17 Apr, 10:15 PM Test Summary: 56636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10635

  59. Elmar Hinz uploaded patch set 27 04/23/17, 14:40

  60. TYPO3com voted on patch set 27 V +1 04/23/17, 14:51 Completed build in 10m 23s on Sun, 23 Apr, 04:51 PM Test Summary: 55800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10874

  61. Elmar Hinz rebased onto patch set 28 04/23/17, 14:51

  62. TYPO3com voted on patch set 28 V +1 04/23/17, 14:59 Completed build in 08m 08s on Sun, 23 Apr, 04:59 PM Test Summary: 55800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10875

  63. Elmar Hinz uploaded patch set 29 04/23/17, 16:50

  64. TYPO3com voted on patch set 29 V -1 04/23/17, 16:59 Completed build in 08m 54s on Sun, 23 Apr, 06:59 PM Test Summary: 55800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10878

  65. Elmar Hinz uploaded patch set 30 04/23/17, 17:25

  66. TYPO3com voted on patch set 30 V +1 04/23/17, 17:38 Completed build in 12m 56s on Sun, 23 Apr, 07:38 PM Test Summary: 55800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10879

  67. Elmar Hinz uploaded patch set 31 04/23/17, 22:17

  68. TYPO3com voted on patch set 31 V -1 04/23/17, 22:23 Completed build in 06m 25s on Mon, 24 Apr, 12:23 AM Test Summary: 290 of 55857 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10886

  69. Elmar Hinz uploaded patch set 32 04/23/17, 22:35

  70. TYPO3com voted on patch set 32 V -1 04/23/17, 22:41 Completed build in 06m 09s on Mon, 24 Apr, 12:41 AM Test Summary: 222 of 55857 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10887

  71. Elmar Hinz updated the commit message in patch set 33 04/24/17, 00:40

  72. TYPO3com voted on patch set 33 V -1 04/24/17, 00:48 Completed build in 07m 36s on Mon, 24 Apr, 02:48 AM Test Summary: 318 of 55857 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10889

  73. Elmar Hinz uploaded patch set 34 04/24/17, 10:59

  74. TYPO3com voted on patch set 34 V -1 04/24/17, 11:09 Completed build in 10m 06s on Mon, 24 Apr, 01:09 PM Test Summary: 142 of 55857 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10892

  75. Elmar Hinz uploaded patch set 35 04/24/17, 13:12

  76. TYPO3com voted on patch set 35 V -1 04/24/17, 13:22 Completed build in 09m 36s on Mon, 24 Apr, 03:22 PM Test Summary: 571 of 55941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10899

  77. Elmar Hinz uploaded patch set 36 04/24/17, 13:36

  78. TYPO3com voted on patch set 36 V -1 04/24/17, 13:45 Completed build in 08m 55s on Mon, 24 Apr, 03:45 PM Test Summary: 635 of 55941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10900

  79. Elmar Hinz uploaded patch set 37 04/24/17, 15:53

  80. Elmar Hinz uploaded patch set 38 04/24/17, 15:57

  81. TYPO3com voted on patch set 37 V -1 04/24/17, 16:00 Completed build in 07m 11s on Mon, 24 Apr, 06:00 PM Test Summary: 687 of 55977 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10902

  82. TYPO3com voted on patch set 38 V -1 04/24/17, 16:04 Completed build in 07m 09s on Mon, 24 Apr, 06:04 PM Test Summary: 1076 of 55977 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10903

  83. Elmar Hinz uploaded patch set 39 04/24/17, 16:10

  84. TYPO3com voted on patch set 39 V -1 04/24/17, 16:16 Completed build in 06m 16s on Mon, 24 Apr, 06:16 PM Test Summary: 1034 of 55977 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10904

  85. Elmar Hinz uploaded patch set 40 04/24/17, 16:29

  86. TYPO3com voted on patch set 40 V +1 04/24/17, 16:36 Completed build in 07m 32s on Mon, 24 Apr, 06:36 PM Test Summary: 55968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10905

  87. Elmar Hinz uploaded patch set 41 04/25/17, 13:06

  88. TYPO3com voted on patch set 41 V -1 04/25/17, 13:17 Completed build in 10m 35s on Tue, 25 Apr, 03:17 PM Test Summary: 16 of 55995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10949

  89. Elmar Hinz uploaded patch set 42 04/25/17, 14:03

  90. TYPO3com voted on patch set 42 V -1 04/25/17, 14:09 Completed build in 05m 59s on Tue, 25 Apr, 04:09 PM Test Summary: 291 of 55995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10953

  91. Elmar Hinz uploaded patch set 43 04/25/17, 14:29

  92. TYPO3com voted on patch set 43 V -1 04/25/17, 14:41 Completed build in 11m 58s on Tue, 25 Apr, 04:41 PM Test Summary: 665 of 55995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10955

  93. Elmar Hinz uploaded patch set 44 04/25/17, 14:57

  94. TYPO3com voted on patch set 44 V -1 04/25/17, 15:03 Completed build in 06m 05s on Tue, 25 Apr, 05:03 PM Test Summary: 104 of 55995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10956

  95. Elmar Hinz uploaded patch set 45 04/25/17, 15:30

  96. TYPO3com voted on patch set 45 V +1 04/25/17, 15:40 Completed build in 10m 35s on Tue, 25 Apr, 05:40 PM Test Summary: 55992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10957

  97. Elmar Hinz uploaded patch set 46 04/25/17, 16:16

  98. TYPO3com voted on patch set 46 V +1 04/25/17, 16:31 Completed build in 12m 36s on Tue, 25 Apr, 06:31 PM Test Summary: 55992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10959

  99. Elmar Hinz uploaded patch set 47 04/25/17, 17:57

  100. TYPO3com voted on patch set 47 V +1 04/25/17, 18:03 Completed build in 06m 16s on Tue, 25 Apr, 08:03 PM Test Summary: 56010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10961

  101. Elmar Hinz uploaded patch set 48 04/25/17, 18:13

  102. TYPO3com voted on patch set 48 V +1 04/25/17, 18:19 Completed build in 06m 25s on Tue, 25 Apr, 08:19 PM Test Summary: 56010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10962

  103. Elmar Hinz uploaded patch set 49 04/25/17, 18:40

  104. TYPO3com voted on patch set 49 V -1 04/25/17, 18:49 Completed build in 08m 26s on Tue, 25 Apr, 08:49 PM Test Summary: 56010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10963

  105. Elmar Hinz uploaded patch set 50 04/26/17, 09:04

  106. TYPO3com voted on patch set 50 V -1 04/26/17, 09:12 Completed build in 07m 41s on Wed, 26 Apr, 11:12 AM Test Summary: 32 of 55995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10967

  107. Elmar Hinz uploaded patch set 51 04/26/17, 13:18

  108. TYPO3com voted on patch set 51 V +1 04/26/17, 13:26 Completed build in 07m 29s on Wed, 26 Apr, 03:26 PM Test Summary: 55992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10977

  109. Elmar Hinz uploaded patch set 52 04/26/17, 13:45

  110. TYPO3com voted on patch set 52 V +1 04/26/17, 13:51 Completed build in 05m 49s on Wed, 26 Apr, 03:51 PM Test Summary: 55992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10981

  111. Elmar Hinz uploaded patch set 53 04/26/17, 14:03

  112. TYPO3com voted on patch set 53 V +1 04/26/17, 14:10 Completed build in 06m 47s on Wed, 26 Apr, 04:10 PM Test Summary: 55992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10982

  113. Elmar Hinz uploaded patch set 54 04/26/17, 14:32

  114. TYPO3com voted on patch set 54 V -1 04/26/17, 14:39 Completed build in 06m 25s on Wed, 26 Apr, 04:39 PM Test Summary: 56010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10983

  115. Elmar Hinz uploaded patch set 55 04/27/17, 00:18

  116. TYPO3com voted on patch set 55 V -1 04/27/17, 00:24 Completed build in 06m 31s on Thu, 27 Apr, 02:24 AM Test Summary: 75 of 56036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11011

  117. TYPO3com commented on patch set 55 04/27/17, 10:33 Completed build in 10h 21m 55s on Thu, 27 Apr, 12:33 PM Test Summary: 75 of 56036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11011

  118. Elmar Hinz uploaded patch set 56 04/27/17, 12:58

  119. TYPO3com voted on patch set 56 V +1 04/27/17, 13:03 Completed build in 05m 33s on Thu, 27 Apr, 03:03 PM Test Summary: 56046 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11038

  120. TYPO3com commented on patch set 55 04/27/17, 13:10 Completed build in 23h 14m 35s on Thu, 27 Apr, 03:10 PM Test Summary: 72 of 56037 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11011

  121. Elmar Hinz uploaded patch set 57 04/27/17, 18:40

  122. TYPO3com voted on patch set 57 V +1 04/27/17, 18:46 Completed build in 05m 22s on Thu, 27 Apr, 08:46 PM Test Summary: 56064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11061

  123. Elmar Hinz uploaded patch set 58 04/28/17, 10:16

  124. TYPO3com voted on patch set 58 V +1 04/28/17, 10:21 Completed build in 05m 08s on Fri, 28 Apr, 12:21 PM Test Summary: 56076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11075

  125. Elmar Hinz uploaded patch set 59 04/28/17, 10:45

  126. TYPO3com voted on patch set 59 V +1 04/28/17, 10:51 Completed build in 05m 36s on Fri, 28 Apr, 12:51 PM Test Summary: 56076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11076

  127. Elmar Hinz uploaded patch set 60 04/28/17, 15:47

  128. TYPO3com voted on patch set 60 V -1 04/28/17, 15:53 Completed build in 05m 22s on Fri, 28 Apr, 05:53 PM Test Summary: 56076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11086

  129. Elmar Hinz uploaded patch set 61 04/28/17, 15:55

  130. TYPO3com voted on patch set 61 V +1 04/28/17, 16:01 Completed build in 05m 00s on Fri, 28 Apr, 06:01 PM Test Summary: 56076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11087

  131. Elmar Hinz uploaded patch set 62 04/28/17, 18:19

  132. TYPO3com voted on patch set 62 V +1 04/28/17, 18:24 Completed build in 05m 26s on Fri, 28 Apr, 08:24 PM Test Summary: 56094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11088

  133. Elmar Hinz uploaded patch set 63 04/28/17, 22:43

  134. TYPO3com voted on patch set 63 V +1 04/28/17, 22:49 Completed build in 05m 38s on Sat, 29 Apr, 12:49 AM Test Summary: 56094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11090

  135. Elmar Hinz uploaded patch set 64 04/29/17, 11:40

  136. TYPO3com voted on patch set 64 V +1 04/29/17, 11:48 Completed build in 08m 26s on Sat, 29 Apr, 01:48 PM Test Summary: 56094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11093

  137. Elmar Hinz uploaded patch set 65 04/29/17, 13:28

  138. TYPO3com voted on patch set 65 V +1 04/29/17, 13:34 Completed build in 05m 46s on Sat, 29 Apr, 03:34 PM Test Summary: 56082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11095

  139. Elmar Hinz uploaded patch set 66 04/29/17, 14:49

  140. TYPO3com voted on patch set 66 V +1 04/29/17, 14:55 Completed build in 06m 03s on Sat, 29 Apr, 04:55 PM Test Summary: 56076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11096

  141. Elmar Hinz uploaded patch set 67 04/29/17, 18:27

  142. TYPO3com voted on patch set 67 V -1 04/29/17, 18:32 Completed build in 05m 27s on Sat, 29 Apr, 08:32 PM Test Summary: 56172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11100

  143. Elmar Hinz uploaded patch set 68 04/29/17, 19:48

  144. TYPO3com voted on patch set 68 V +1 04/29/17, 19:53 Completed build in 05m 16s on Sat, 29 Apr, 09:53 PM Test Summary: 56172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11102

  145. Elmar Hinz uploaded patch set 69 04/30/17, 03:47

  146. TYPO3com voted on patch set 69 V -1 04/30/17, 03:52 Completed build in 05m 22s on Sun, 30 Apr, 05:52 AM Test Summary: 1 of 56187 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11103

  147. Elmar Hinz uploaded patch set 70 04/30/17, 07:58

  148. TYPO3com voted on patch set 70 V +1 04/30/17, 08:04 Completed build in 05m 32s on Sun, 30 Apr, 10:04 AM Test Summary: 56184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11104

  149. Elmar Hinz uploaded patch set 71 04/30/17, 15:54

  150. TYPO3com voted on patch set 71 V +1 04/30/17, 15:59 Completed build in 05m 08s on Sun, 30 Apr, 05:59 PM Test Summary: 56178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11106

  151. Elmar Hinz uploaded patch set 72 05/01/17, 15:32

  152. TYPO3com voted on patch set 72 V +1 05/01/17, 15:38 Completed build in 05m 44s on Mon, 1 May, 05:38 PM Test Summary: 56238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11116

  153. Oliver Klee commented on patch set 72 05/01/17, 15:50

    MountPointResolver.php:41

    We should have an @var annotation for all constants.

    MountPointResolver.php:80

    return type bool

    MountPointResolver.php:133

    return type bool

    MountPointResolver.php:160

    return type bool
  154. Elmar Hinz uploaded patch set 73 05/01/17, 21:24

  155. TYPO3com voted on patch set 73 V +1 05/01/17, 21:29 Completed build in 05m 12s on Mon, 1 May, 11:29 PM Test Summary: 56238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11117

  156. Elmar Hinz uploaded patch set 74 05/02/17, 00:38

  157. TYPO3com voted on patch set 74 V -1 05/02/17, 00:43 Completed build in 05m 18s on Tue, 2 May, 02:43 AM Test Summary: 6 of 56247 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11118

  158. Elmar Hinz uploaded patch set 75 05/02/17, 10:13

  159. TYPO3com voted on patch set 75 V -1 05/02/17, 10:18 Completed build in 05m 10s on Tue, 2 May, 12:18 PM Test Summary: 652 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11126

  160. Elmar Hinz uploaded patch set 76 05/02/17, 12:08

  161. TYPO3com voted on patch set 76 V -1 05/02/17, 12:13 Completed build in 05m 08s on Tue, 2 May, 02:13 PM Test Summary: 646 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11127

  162. Elmar Hinz rebased onto patch set 77 05/02/17, 12:27

  163. TYPO3com voted on patch set 77 V -1 05/02/17, 12:33 Completed build in 05m 42s on Tue, 2 May, 02:33 PM Test Summary: 646 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11128

  164. Elmar Hinz uploaded patch set 78 05/02/17, 14:47

  165. TYPO3com voted on patch set 78 V -1 05/02/17, 14:52 Completed build in 05m 04s on Tue, 2 May, 04:52 PM Test Summary: 624 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11134

  166. Elmar Hinz uploaded patch set 79 05/02/17, 16:12

  167. TYPO3com voted on patch set 79 V -1 05/02/17, 16:17 Completed build in 04m 58s on Tue, 2 May, 06:17 PM Test Summary: 624 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11136

  168. Elmar Hinz uploaded patch set 80 05/02/17, 19:19

  169. TYPO3com voted on patch set 80 V -1 05/02/17, 19:24 Completed build in 04m 59s on Tue, 2 May, 09:24 PM Test Summary: 624 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11151

  170. Elmar Hinz uploaded patch set 81 05/02/17, 19:53

  171. TYPO3com voted on patch set 81 V -1 05/02/17, 19:58 Completed build in 05m 18s on Tue, 2 May, 09:58 PM Test Summary: 617 of 47162 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11152

  172. Elmar Hinz uploaded patch set 82 05/02/17, 20:17

  173. TYPO3com voted on patch set 82 V -1 05/02/17, 20:22 Completed build in 05m 19s on Tue, 2 May, 10:22 PM Test Summary: 8 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11153

  174. Elmar Hinz uploaded patch set 83 05/02/17, 20:30

  175. TYPO3com voted on patch set 83 V -1 05/02/17, 20:33 Completed build in 02m 45s on Tue, 2 May, 10:33 PM Test Summary: 6853 of 55980 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11154

  176. Elmar Hinz uploaded patch set 84 05/02/17, 20:34

  177. TYPO3com voted on patch set 84 V -1 05/02/17, 20:40 Completed build in 05m 14s on Tue, 2 May, 10:40 PM Test Summary: 30 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11155

  178. Elmar Hinz uploaded patch set 85 05/02/17, 20:44

  179. TYPO3com voted on patch set 85 V -1 05/02/17, 20:49 Completed build in 05m 15s on Tue, 2 May, 10:49 PM Test Summary: 8 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11156

  180. Elmar Hinz uploaded patch set 86 05/03/17, 04:25

  181. TYPO3com voted on patch set 86 V -1 05/03/17, 04:30 Completed build in 05m 25s on Wed, 3 May, 06:30 AM Test Summary: 8 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11160

  182. Elmar Hinz uploaded patch set 87 05/03/17, 04:51

  183. TYPO3com voted on patch set 87 V +1 05/03/17, 04:56 Completed build in 05m 23s on Wed, 3 May, 06:56 AM Test Summary: 56130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11161

  184. Elmar Hinz uploaded patch set 88 05/03/17, 06:04

  185. TYPO3com voted on patch set 88 V +1 05/03/17, 06:10 Completed build in 05m 25s on Wed, 3 May, 08:10 AM Test Summary: 56130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11162

  186. Elmar Hinz uploaded patch set 89 05/06/17, 15:51

  187. TYPO3com voted on patch set 89 V -1 05/06/17, 15:56 Completed build in 05m 02s on Sat, 6 May, 05:56 PM Test Summary: 1249 of 56133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11252

  188. Elmar Hinz uploaded patch set 90 05/08/17, 11:16

  189. TYPO3com voted on patch set 90 V +1 05/08/17, 11:21 Completed build in 05m 11s on Mon, 8 May, 01:21 PM Test Summary: 56124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11265

  190. Elmar Hinz uploaded patch set 91 05/08/17, 14:40

  191. TYPO3com voted on patch set 91 V +1 05/08/17, 14:45 Completed build in 05m 27s on Mon, 8 May, 04:45 PM Test Summary: 56178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11269

  192. Elmar Hinz uploaded patch set 92 05/10/17, 12:37

  193. TYPO3com voted on patch set 92 V +1 05/10/17, 12:42 Completed build in 05m 21s on Wed, 10 May, 02:42 PM Test Summary: 56184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11340

  194. Elmar Hinz uploaded patch set 93 05/10/17, 12:48

  195. TYPO3com voted on patch set 93 V +1 05/10/17, 12:54 Completed build in 05m 30s on Wed, 10 May, 02:54 PM Test Summary: 56184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11341

  196. Elmar Hinz uploaded patch set 94 05/10/17, 13:59

  197. TYPO3com voted on patch set 94 V +1 05/10/17, 14:05 Completed build in 05m 45s on Wed, 10 May, 04:05 PM Test Summary: 56166 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11343

  198. Elmar Hinz uploaded patch set 95 05/10/17, 14:30

  199. TYPO3com voted on patch set 95 V +1 05/10/17, 14:36 Completed build in 05m 32s on Wed, 10 May, 04:36 PM Test Summary: 56172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11346

  200. Elmar Hinz uploaded patch set 96 05/10/17, 14:52

  201. TYPO3com voted on patch set 96 V +1 05/10/17, 15:03 Completed build in 09m 52s on Wed, 10 May, 05:03 PM Test Summary: 56172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11347

  202. Elmar Hinz uploaded patch set 97 05/10/17, 16:11

  203. TYPO3com voted on patch set 97 V +1 05/10/17, 16:17 Completed build in 05m 30s on Wed, 10 May, 06:17 PM Test Summary: 56190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11351

  204. Elmar Hinz uploaded patch set 98 05/10/17, 20:18

  205. TYPO3com voted on patch set 98 V +1 05/10/17, 20:24 Completed build in 05m 25s on Wed, 10 May, 10:24 PM Test Summary: 56196 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11357

  206. Elmar Hinz updated the commit message in patch set 99 05/10/17, 20:25

  207. TYPO3com voted on patch set 99 V +1 05/10/17, 20:31 Completed build in 05m 18s on Wed, 10 May, 10:31 PM Test Summary: 56196 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11358

  208. Tymoteusz Motylewski commented on patch set 99 05/11/17, 09:22

    great work, did not dig into details yet, just a small nitpic regarding documentation. Each feature needs an RST file which is placed in typo3/sysext/core/Documentation/Changelog/master You can generate this file with a tool on forger: https://forger.typo3.org/utility/rst So the content of the readme can go into this file. Later these files are automatically rendered on docs.typo3.org e.g. https://docs.typo3.org/typo3cms/extensions/core/8.7/Changelog/8.7/Index.html
  209. Elmar Hinz uploaded patch set 100 05/12/17, 16:24

  210. TYPO3com voted on patch set 100 V -1 05/12/17, 16:31 Completed build in 06m 19s on Fri, 12 May, 06:31 PM Test Summary: 56252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11468

  211. Elmar Hinz uploaded patch set 101 05/12/17, 17:23

  212. TYPO3com voted on patch set 101 V +1 05/12/17, 17:31 Completed build in 08m 30s on Fri, 12 May, 07:31 PM Test Summary: 56252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11469

  213. Elmar Hinz uploaded patch set 102 05/13/17, 15:30

  214. TYPO3com voted on patch set 102 V +1 05/13/17, 15:39 Completed build in 08m 10s on Sat, 13 May, 05:39 PM Test Summary: 56252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11483

  215. Elmar Hinz uploaded patch set 103 05/15/17, 14:01

  216. TYPO3com voted on patch set 103 V +1 05/15/17, 14:07 Completed build in 06m 07s on Mon, 15 May, 04:07 PM Test Summary: 56240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11500

  217. Elmar Hinz uploaded patch set 104 05/15/17, 15:06

  218. TYPO3com voted on patch set 104 V +1 05/15/17, 15:12 Completed build in 05m 55s on Mon, 15 May, 05:12 PM Test Summary: 56240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11502

  219. Claus Due commented on patch set 104 CR -1 05/15/17, 15:21

    I would *not* start putting RST files in our class directories, e.g. typo3/sysext/core/Classes/RootLine/README.rst. That's a door we don't want to open IMHO.
  220. Mathias Brodala commented on patch set 104 05/15/17, 15:31

    > I would *not* start putting RST files in our class directories, > e.g. typo3/sysext/core/Classes/RootLine/README.rst. That's a door > we don't want to open IMHO. I agree. Simply move this into the changelog directory as Important RST.
  221. Tymoteusz Motylewski commented on patch set 104 05/15/17, 15:35

    As I proposed few patchset before, it should be marked as Feature, and an feature rst file should be provided.
  222. Elmar Hinz commented on patch set 104 05/15/17, 16:05

    > As I proposed few patchset before, it should be marked as Feature, > and an feature rst file should be provided. I don't want to sell this change set as feature. When I apply the root line objects, practice will show what API and what features the really need. They will get a lot more methods. This would result in a second feature RST, splitting it into two parts. That's the reason why I set everything to internal and sell this one fully as drop in replacement of RootlineUtility. As such I think [CLEANUP] is a better label. There a no features for now. Please correct me if this considerations are wrong.
  223. Elmar Hinz commented on patch set 104 05/15/17, 18:43

    @Tymoteusz If I would add a feature.rst with this ticket, would it be allowed to update it with the second ticket.
  224. Elmar Hinz uploaded patch set 105 05/17/17, 09:44

  225. TYPO3com voted on patch set 105 V -1 05/17/17, 09:50 Completed build in 05m 47s on Wed, 17 May, 11:50 AM Test Summary: 1 of 56249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11537

  226. Mathias Brodala commented on patch set 105 05/17/17, 09:53

    Feature-80854-RootLineAndRootLineRepsitory.rst

    Tiny nitpick: can you fix the filename? ("Repsitory")

    Important-80854-RootLineRepository.rst

    I'd move this into the feature RST.
  227. Elmar Hinz uploaded patch set 106 05/17/17, 10:15

  1. TYPO3com voted on patch set 106 V +1 05/17/17, 10:20 Completed build in 05m 12s on Wed, 17 May, 12:20 PM Test Summary: 56246 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11539

  2. Mathias Schreiber uploaded patch set 107 02/07/18, 19:55

  3. TYPO3com voted on patch set 107 V -1 02/07/18, 19:56 Completed build in 10s on Wed, 7 Feb, 08:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19093

  4. Mathias Schreiber uploaded patch set 108 02/07/18, 19:58

  5. TYPO3com voted on patch set 108 V -1 02/07/18, 20:04 Completed build in 06m 50s on Wed, 7 Feb, 09:04 PM Test Summary: 3 of 30814 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19094

  6. Mathias Schreiber uploaded patch set 109 02/07/18, 20:26

  7. TYPO3com voted on patch set 109 V +1 02/07/18, 20:32 Completed build in 05m 47s on Wed, 7 Feb, 09:32 PM Test Summary: 30656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19097

  8. Susi Moog uploaded patch set 110 02/09/18, 20:10

  9. TYPO3com voted on patch set 110 V -1 02/09/18, 20:23 Completed build in 12m 39s on Fri, 9 Feb, 09:23 PM Test Summary: 758 of 30820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19221

  10. TYPO3com commented on patch set 110 02/09/18, 20:34 Completed build in 37m 09s on Fri, 9 Feb, 09:34 PM Test Summary: 758 of 30820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19221

  11. Anja Leichsenring uploaded patch set 111 04/14/18, 16:07

  12. TYPO3com voted on patch set 111 V -1 04/14/18, 16:07 Completed build in 10s on Sat, 14 Apr, 06:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22334

  13. Anja Leichsenring uploaded patch set 112 04/14/18, 16:08

  14. TYPO3com voted on patch set 112 V -1 04/14/18, 16:17 Completed build in 09m 05s on Sat, 14 Apr, 06:17 PM Test Summary: 819 of 31295 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22335

  15. Anja Leichsenring uploaded patch set 113 04/14/18, 16:19

  16. TYPO3com voted on patch set 113 V -1 04/14/18, 16:27 Completed build in 08m 03s on Sat, 14 Apr, 06:27 PM Test Summary: 45 of 31295 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22336

  17. Anja Leichsenring uploaded patch set 114 04/14/18, 17:03

  18. TYPO3com voted on patch set 114 V -1 04/14/18, 17:03 Completed build in 11s on Sat, 14 Apr, 07:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22337

  19. Anja Leichsenring uploaded patch set 115 04/14/18, 17:04

  20. Claus Due wrote 04/14/18, 17:07

    Removed reviewer Claus Due.
  21. TYPO3com voted on patch set 115 V +1 04/14/18, 17:13 Completed build in 08m 30s on Sat, 14 Apr, 07:13 PM Test Summary: 31143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22338

  22. Anja Leichsenring voted on patch set 115 V +1 04/14/18, 17:14

  23. Michele Martinello voted on patch set 115 CR +1 05/10/18, 15:14

  24. Anja Leichsenring wrote 06/01/18, 11:26

    Removed Verified+1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  25. Benni Mack abandoned the change 06/10/18, 19:07

    we'll split that patch up in different parts as mount point resolver and rootline builder concept. will abandon this one for now though.