Review main Merged

52465[BUGFIX] Fix path to Header partial in Textmedia and Textpic

TYPO3com CR +2 V +2 Easy +2 −2 updated 05/11/17, 11:49

Commit message

Fix path to call the existing partial Partials/Header/All instead of
Partials/Header.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1724

  1. TYPO3com uploaded patch set 1 04/16/17, 14:31

  2. TYPO3com voted on patch set 1 V +1 04/16/17, 14:40 Completed build in 09m 00s on Sun, 16 Apr, 04:40 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10608

  3. Stefan Neufeind voted on patch set 1 CR +1 04/18/17, 02:54

  4. Henrik Elsner voted on patch set 1 CR +1 04/18/17, 07:21

  5. Riccardo De Contardi commented on patch set 1 CR -1 04/25/17, 21:44

    same error is present also for textpic (EXT:fluid_styled_content/Resources/Private/Templates/Textpic.html
  6. Riccardo De Contardi uploaded patch set 2 04/26/17, 22:01

  7. TYPO3com voted on patch set 2 V -1 04/26/17, 22:15 Completed build in 13m 29s on Thu, 27 Apr, 12:15 AM Test Summary: 13 of 55780 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11008

  8. TYPO3com commented on patch set 2 04/26/17, 22:28 Completed build in 39m 33s on Thu, 27 Apr, 12:28 AM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11008

  9. TYPO3com voted on patch set 2 V +1 04/26/17, 22:33 Completed build in 1h 10m 38s on Thu, 27 Apr, 12:33 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11008

  10. Oliver Klee commented on patch set 2 05/02/17, 13:27

    Does this also affect 8.7?
  11. Wouter Wolters updated the commit message in patch set 3 05/02/17, 18:09

  12. Wouter Wolters voted on patch set 3 CR +1 05/02/17, 18:11

  13. Oliver Klee voted on patch set 3 CR +1 05/02/17, 18:19

  14. TYPO3com voted on patch set 3 V +1 05/02/17, 18:19 Completed build in 09m 52s on Tue, 2 May, 08:19 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11141

  15. Stefan Neufeind commented on patch set 3 CR +1 V +1 05/02/17, 20:42

    to test simply use a textmedia/textpic without bodytext
  16. Stefan Neufeind commented on patch set 3 05/02/17, 20:58

    fit -> fix
  17. Henrik Elsner voted on patch set 3 CR +1 05/03/17, 11:18

  18. Elmar Hinz updated the commit message in patch set 4 05/11/17, 10:44

  19. Stefan Neufeind commented on patch set 4 CR +1 V +1 05/11/17, 10:49

    reapplying votes
  20. TYPO3com voted on patch set 4 V +1 05/11/17, 10:49 Completed build in 05m 08s on Thu, 11 May, 12:49 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11373

  21. Anja Leichsenring voted on patch set 4 CR +1 V +1 05/11/17, 11:48

  22. Stefan Neufeind voted on patch set 4 CR +2 V +2 05/11/17, 11:49

  23. Gerrit merged patch set 4 05/11/17, 11:49

  24. Stefan Neufeind commented on patch set 5 05/11/17, 11:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 74ddc0c2b981f893d51061b760070bce2d6881d0