Review main Merged

52467[FEATURE] Allow exclusion of records in localization wizard

Andreas Kienast CR +2 V +2 Normal +105 −5 updated 05/05/17, 14:17

Commit message

This patch adds a checkbox next to each record that is about to be
localized in the wizard. All checkboxes are enabled by default.

Additionally, a filter is introduced that checks that all transmitted UIDs
are actually localizable and removes invalid values.

Review

  • Code review CR +2
    • Jan Helke +2
    • Henrik Elsner +1
  • Verified V +2
    • Jan Helke +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1519

  1. Andreas Kienast uploaded patch set 1 04/17/17, 10:30

  2. Andreas Kienast commented on patch set 1 CR -2 04/17/17, 10:30

    Blocked until development for CMS 9 is open
  3. TYPO3com voted on patch set 1 V +1 04/17/17, 10:39 Completed build in 09m 27s on Mon, 17 Apr, 12:39 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10619

  4. Andreas Kienast uploaded patch set 2 04/17/17, 10:47

  5. TYPO3com voted on patch set 2 V +1 04/17/17, 10:54 Completed build in 07m 16s on Mon, 17 Apr, 12:54 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10620

  6. Andreas Kienast voted on patch set 2 CR 0 04/18/17, 04:40

  7. Tymoteusz Motylewski commented on patch set 2 04/27/17, 13:53

    let's call it a FEATURE please

    LocalizationController.php:215

    hmm, it would be interesting to know when you will get invalid uids from the previous step and fix it there.
  8. Andreas Kienast commented on patch set 2 04/27/17, 13:58

    LocalizationController.php:215 Reply

    Browser's inspector > change assigned uid in checkbox ;) That's at least what I would do if something does not work as expected :D
  9. Tymoteusz Motylewski commented on patch set 2 04/27/17, 16:00

    LocalizationController.php:215 Reply

    So it's not possible by normal usage of the backend? so this method is just a "security" measure when sb try to manually send incorrect data?
  10. Andreas Kienast commented on patch set 2 04/27/17, 17:08

    LocalizationController.php:215 Reply

    Exactly
  11. Andreas Kienast uploaded patch set 3 04/27/17, 17:17

  12. TYPO3com voted on patch set 3 V +1 04/27/17, 17:23 Completed build in 05m 34s on Thu, 27 Apr, 07:23 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11054

  13. Henrik Elsner commented on patch set 3 CR +1 05/05/17, 08:20

    Disabling the translation for the only element in column results in an endless processing screen (can be escaped) - should that case be intercepted ?

    Localization.js:169

    .form-control sets the height to 32px. This means content with longer headlines are cut off -- the header is not fully readable or overflowing the label
  14. Henrik Elsner voted on patch set 3 CR 0 V -1 05/05/17, 08:40

  15. Andreas Kienast uploaded patch set 4 05/05/17, 08:43

  16. TYPO3com voted on patch set 4 V +1 05/05/17, 08:48 Completed build in 05m 15s on Fri, 5 May, 10:48 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11214

  17. Henrik Elsner commented on patch set 4 CR +1 V +1 05/05/17, 08:55

    Works - looks good - nice one
  18. Jan Helke voted on patch set 4 CR +2 V +2 05/05/17, 14:17

  19. Gerrit merged patch set 4 05/05/17, 14:17