Review main Merged

52516[BUGFIX] CKEditor: Configuration properties not translatable

Thorben Nissen CR +2 V +2 Easy +22 −2 updated 04/27/17, 14:19

Commit message

Adding custom stylesSets it is not possible to use "LLL:..." syntax. I
would be just display as is.

Add recursive resolving of "LLL:..." references in the configuration
properties.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Thorben Nissen +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Thorben Nissen +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Thorben Nissen uploaded patch set 1 04/20/17, 12:20

  2. TYPO3com voted on patch set 1 V +1 04/20/17, 12:31 Completed build in 10m 55s on Thu, 20 Apr, 02:31 PM Test Summary: 55898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10772

  3. Benni Mack commented on patch set 2 04/20/17, 12:35

    Published edit on patch set 1.
  4. Benni Mack voted on patch set 2 CR +1 04/20/17, 12:35

  5. TYPO3com voted on patch set 2 V +1 04/20/17, 12:50 Completed build in 15m 02s on Thu, 20 Apr, 02:50 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10774

  6. Frans Saris voted on patch set 2 CR +1 04/20/17, 16:55

  7. Henrik Elsner voted on patch set 2 CR +1 04/21/17, 09:37

  8. Tymoteusz Motylewski commented on patch set 2 04/21/17, 10:30

    how can I reproduce/test it?
  9. Thorben Nissen commented on patch set 2 04/21/17, 10:36

    Add a stylesSet in the RTE preset, e.g. editor: config: stylesSet: - { name: "LLL:EXT:some_ext/Resources/Private/...", ... } The "styles" button/select must be enabled, which is not the case in the Default.yaml but in the Full.yaml. Without the patch, the style select display the entered "LLL:EXT:some_ext/Resources/Private/..." as label. With the patch the translated value is shown. I hope this helps.
  10. Benni Mack voted on patch set 2 V +1 04/27/17, 09:29

  11. Wouter Wolters commented on patch set 2 CR -1 04/27/17, 14:01

    on it

    RichTextElement.php:243

    stripos should be used here
  12. Wouter Wolters uploaded patch set 3 04/27/17, 14:06

  13. Wouter Wolters voted on patch set 3 CR +1 V +1 04/27/17, 14:07

  14. Thorben Nissen voted on patch set 3 CR +1 V +1 04/27/17, 14:09

  15. TYPO3com voted on patch set 3 V +1 04/27/17, 14:12 Completed build in 05m 54s on Thu, 27 Apr, 04:12 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11042

  16. Benni Mack voted on patch set 3 CR +2 V +2 04/27/17, 14:18

  17. Gerrit merged patch set 3 04/27/17, 14:18

  18. Benni Mack commented on patch set 4 04/27/17, 14:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ca7f7efef32b49a14a6dba5c2c4d59b77f4019f8