52516[BUGFIX] CKEditor: Configuration properties not translatable
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Thorben Nissen +1
-
Verified V +2
- Benni Mack +2
- Wouter Wolters +1
- Thorben Nissen +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1518
-
Thorben Nissen uploaded patch set 1 04/20/17, 12:20
-
TYPO3com voted on patch set 1 V +1 04/20/17, 12:31 Completed build in 10m 55s on Thu, 20 Apr, 02:31 PM Test Summary: 55898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10772
-
Benni Mack commented on patch set 2 04/20/17, 12:35
Published edit on patch set 1. -
Benni Mack voted on patch set 2 CR +1 04/20/17, 12:35
-
TYPO3com voted on patch set 2 V +1 04/20/17, 12:50 Completed build in 15m 02s on Thu, 20 Apr, 02:50 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10774
-
Frans Saris voted on patch set 2 CR +1 04/20/17, 16:55
-
Henrik Elsner voted on patch set 2 CR +1 04/21/17, 09:37
-
Tymoteusz Motylewski commented on patch set 2 04/21/17, 10:30
how can I reproduce/test it? -
Thorben Nissen commented on patch set 2 04/21/17, 10:36
Add a stylesSet in the RTE preset, e.g. editor: config: stylesSet: - { name: "LLL:EXT:some_ext/Resources/Private/...", ... } The "styles" button/select must be enabled, which is not the case in the Default.yaml but in the Full.yaml. Without the patch, the style select display the entered "LLL:EXT:some_ext/Resources/Private/..." as label. With the patch the translated value is shown. I hope this helps. -
Benni Mack voted on patch set 2 V +1 04/27/17, 09:29
-
Wouter Wolters commented on patch set 2 CR -1 04/27/17, 14:01
on itRichTextElement.php:243stripos should be used here -
Wouter Wolters uploaded patch set 3 04/27/17, 14:06
-
Wouter Wolters voted on patch set 3 CR +1 V +1 04/27/17, 14:07
-
Thorben Nissen voted on patch set 3 CR +1 V +1 04/27/17, 14:09
-
TYPO3com voted on patch set 3 V +1 04/27/17, 14:12 Completed build in 05m 54s on Thu, 27 Apr, 04:12 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11042
-
Benni Mack voted on patch set 3 CR +2 V +2 04/27/17, 14:18
-
Gerrit merged patch set 3 04/27/17, 14:18
-
Benni Mack commented on patch set 4 04/27/17, 14:19
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ca7f7efef32b49a14a6dba5c2c4d59b77f4019f8