Review main Merged

52518[TASK] Deprecate GeneralUtility::getUserObj()

Benni Mack CR +2 V +2 Hard +235 −211 updated 04/27/17, 15:02

Commit message

This function now does the same as makeInstance() except for an if()
clause, since the API should be unified this method should be considered
as dropped, allowing to use callUserFunction() and makeInstance() as the
only two proper ways to call custom classes / methods.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 49

Show 29 more files

Review log 57

  1. Benni Mack uploaded patch set 1 04/20/17, 13:47

  2. TYPO3com voted on patch set 1 V +1 04/20/17, 14:00 Completed build in 12m 30s on Thu, 20 Apr, 04:00 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10781

  3. Benni Mack uploaded patch set 2 04/24/17, 16:32

  4. Georg Ringer voted on patch set 2 CR +1 V +1 04/24/17, 16:36

  5. TYPO3com voted on patch set 2 V +1 04/24/17, 16:40 Completed build in 07m 58s on Mon, 24 Apr, 06:40 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10906

  6. Wouter Wolters voted on patch set 2 CR +2 V +2 04/27/17, 15:02

  7. Gerrit merged patch set 2 04/27/17, 15:02