Review main Merged

52519[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string

Daniel Goerz CR +2 V +2 Normal +87 −8 updated 05/11/17, 11:30

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2027

Show 12 earlier messages
  1. Daniel Goerz uploaded patch set 1 04/20/17, 13:49

  2. TYPO3com voted on patch set 1 V +1 04/20/17, 14:05 Completed build in 15m 43s on Thu, 20 Apr, 04:05 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10782

  1. Daniel Goerz uploaded patch set 2 04/20/17, 14:09

  2. TYPO3com voted on patch set 2 V +1 04/20/17, 14:16 Completed build in 06m 58s on Thu, 20 Apr, 04:16 PM Test Summary: 55916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10784

  3. Benni Mack updated the commit message in patch set 3 04/20/17, 16:17

  4. TYPO3com voted on patch set 3 V +1 04/20/17, 16:35 Completed build in 18m 18s on Thu, 20 Apr, 06:35 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10797

  5. Benni Mack commented on patch set 4 04/27/17, 15:16

    Published edit on patch set 3.
  6. TYPO3com voted on patch set 4 V -1 04/27/17, 15:21 Completed build in 04m 45s on Thu, 27 Apr, 05:21 PM Test Summary: 2 of 55815 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11049

  7. Daniel Goerz commented on patch set 4 04/27/17, 15:22

    unrelated failure ...
  8. Daniel Goerz updated the commit message in patch set 5 04/27/17, 16:12

  9. TYPO3com voted on patch set 5 V +1 04/27/17, 16:17 Completed build in 04m 46s on Thu, 27 Apr, 06:17 PM Test Summary: 55812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11052

  10. Oliver Klee voted on patch set 5 CR +1 04/27/17, 17:28

  11. Oliver Klee commented on patch set 5 04/27/17, 17:29

    DataStructureIdentifierHook.php:258

    $key is not used an can be removed, BTW.
  12. Elmar Hinz commented on patch set 4 05/11/17, 07:41

    DataStructureIdentifierHook.php:258

    I don't understand the foreach at all. If it is a path, each array must have only one entry. Otherwise the foreach will create wrong paths by appending multiple keys of the same level. Maybe throw an exception it there are multiple entries in an array?

    DataStructureIdentifierHookTest.php:293

    The accessible mock could be avoided by a plain createMock() in combination with BaseTestCase::callInaccessibleMethod(). A matter of taste.
  13. Anja Leichsenring uploaded patch set 6 05/11/17, 11:01

  14. Anja Leichsenring voted on patch set 6 CR +1 V +1 05/11/17, 11:02

  15. Christian Kuhn commented on patch set 6 CR -1 05/11/17, 11:08

    on it.
  16. TYPO3com voted on patch set 6 V +1 05/11/17, 11:10 Completed build in 08m 34s on Thu, 11 May, 01:10 PM Test Summary: 55836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11374

  17. Christian Kuhn commented on patch set 6 05/11/17, 11:14

    i'll slightly clean up the tests and will rename $array to something better ...
  18. Christian Kuhn uploaded patch set 7 05/11/17, 11:22

  19. Christian Kuhn voted on patch set 7 CR +1 V +1 05/11/17, 11:23

  20. Anja Leichsenring voted on patch set 7 CR +1 V +1 05/11/17, 11:24

  21. Jan Helke voted on patch set 7 CR +1 V +1 05/11/17, 11:26

  22. TYPO3com voted on patch set 7 V +1 05/11/17, 11:28 Completed build in 06m 23s on Thu, 11 May, 01:28 PM Test Summary: 55836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11377

  23. Christian Kuhn voted on patch set 7 CR +2 V +2 05/11/17, 11:30

  24. Gerrit merged patch set 7 05/11/17, 11:30

  25. Christian Kuhn commented on patch set 8 05/11/17, 11:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2cd2c20b315e5e08a8cf4d50b11a017476d51d4f