Review main Merged

52530[BUGFIX] Use correct TypoScriptService in ClickEnlargeViewHelper

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 04/21/17, 07:59

Commit message

The Extbase TypoScriptService is used but should use the one from
the core.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Wouter Wolters uploaded patch set 1 04/20/17, 18:25

  2. TYPO3com voted on patch set 1 V -1 04/20/17, 18:31 Completed build in 06m 43s on Thu, 20 Apr, 08:31 PM Test Summary: 28333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10810

  3. Wouter Wolters rebased onto patch set 2 04/20/17, 18:34

  4. TYPO3com voted on patch set 2 V -1 04/20/17, 18:45 Completed build in 10m 17s on Thu, 20 Apr, 08:45 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10813

  5. Wouter Wolters commented on patch set 3 04/20/17, 18:48

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 04/20/17, 18:54 Completed build in 06m 29s on Thu, 20 Apr, 08:54 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10814

  7. Andreas Kienast voted on patch set 3 CR +1 04/20/17, 19:35

  8. Benni Mack voted on patch set 3 CR +2 V +1 04/20/17, 22:19

  9. Georg Ringer voted on patch set 3 CR +2 V +2 04/21/17, 07:58

  10. Gerrit merged patch set 3 04/21/17, 07:58

  11. Georg Ringer commented on patch set 4 04/21/17, 07:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5cb42a8454e9af1ad472fb89054af4b2ceec269e