Review main Merged

52535[BUGFIX] Use absolute URL for avatars

Benni Mack CR +2 V +2 Easy +1 −5 updated 06/09/17, 13:17

Commit message

Rendering avatar URLs which are not on a remote (gravatar etc)
is the only part which deals with references as in ".." preventing
the TYPO3 Backend entryscript to be placed somewhere else as in typo3/.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Sascha Egerer +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Helmut Hummel +1
    • Henrik Elsner +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Benni Mack uploaded patch set 1 04/20/17, 22:43

  2. TYPO3com voted on patch set 1 V +1 04/20/17, 22:52 Completed build in 08m 46s on Fri, 21 Apr, 12:52 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10824

  3. Benni Mack updated the commit message in patch set 2 04/26/17, 18:21

  4. TYPO3com voted on patch set 2 V +1 04/26/17, 18:27 Completed build in 06m 00s on Wed, 26 Apr, 08:27 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10990

  5. Wouter Wolters voted on patch set 2 CR +1 04/26/17, 18:43

  6. Helmut Hummel voted on patch set 2 CR +1 04/27/17, 09:11

  7. Markus Klein commented on patch set 2 04/27/17, 09:32

    Did you test this also with instances that run in a subdirectory?
  8. Henrik Elsner voted on patch set 2 CR +1 04/28/17, 12:47

  9. Sascha Egerer voted on patch set 2 CR +1 04/29/17, 12:08

  10. Sascha Egerer commented on patch set 2 04/29/17, 12:11

    @Markus that case should be handled by PathUtility::getAbsoluteWebPath(), right?
  11. Markus Klein commented on patch set 2 CR -1 04/29/17, 18:20

    putting a temporary -1 on this one. will test my usecase accordingly.
  12. Markus Klein voted on patch set 2 CR +1 V +1 04/29/17, 20:44

  13. Andreas Kienast voted on patch set 2 CR +2 V +2 05/01/17, 10:58

  14. Gerrit merged patch set 2 05/01/17, 10:58

  15. Andreas Kienast commented on patch set 3 05/01/17, 10:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 01de7c04942e3b700f742cfbe9987b5858c7cd82
  16. Frans Saris commented on patch set 3 06/09/17, 13:17

    post -1 This breaks avatar links like `/typo3/index.php?route....`