Review TYPO3_8-7 Abandoned

52538[BUGFIX] If selected crop variant has empty area then try the 'default' crop variant

Christian Toffolo CR 0 V 0 Easy +26 −2 updated 05/02/17, 18:44

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Christian Toffolo uploaded patch set 1 04/21/17, 06:00

  2. TYPO3com voted on patch set 1 V +1 04/21/17, 06:10 Completed build in 10m 06s on Fri, 21 Apr, 08:10 AM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-27

  3. Wouter Wolters commented on patch set 1 CR -1 04/21/17, 06:46

    This should be pushed to master branch first. And after it gets merged a core team member will backport. Releases line should be Releases: master,8.7

    ImageViewHelper.php:138

    !== and move to if statement above

    ImageViewHelper.php:126

    !== and move to if statement above
  4. Wouter Wolters abandoned the change 05/02/17, 18:44

    master first, after that a new backport is needed