Review main Merged

52539[BUGFIX] Upgrade Wizard must work also on records marked as deleted

Christian Toffolo CR +2 V +2 Easy +10 −15 updated 03/09/18, 22:33

Commit message

Deleted records can be restored using the recycler, therefore the
wizards should check deleted records as well.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • Jigal van Hemert +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1824

  1. Christian Toffolo uploaded patch set 1 04/21/17, 07:37

  2. TYPO3com voted on patch set 1 V +1 04/21/17, 07:48 Completed build in 10m 48s on Fri, 21 Apr, 09:48 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10827

  3. Wouter Wolters updated the commit message in patch set 2 05/02/17, 18:38

  4. TYPO3com voted on patch set 2 V -1 05/02/17, 19:05 Completed build in 26m 54s on Tue, 2 May, 09:05 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11146

  5. Frank Nägler rebased onto patch set 3 02/13/18, 08:44

  6. TYPO3com voted on patch set 3 V -1 02/13/18, 08:52 Completed build in 07m 25s on Tue, 13 Feb, 09:52 AM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19444

  7. TYPO3com voted on patch set 3 V +1 02/14/18, 21:44 Completed build in 13h 07m 39s on Wed, 14 Feb, 10:44 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19444

  8. Anja Leichsenring voted on patch set 3 CR +1 02/14/18, 21:46

  9. Stefan Neufeind commented on patch set 3 CR +1 02/15/18, 05:43

    checked that we don't seem to have missed this DeletedRestriction in other similar places
  10. Anja Leichsenring voted on patch set 3 V +1 02/15/18, 18:18

  11. Anja Leichsenring commented on patch set 3 CR -1 02/16/18, 19:46

    CommandLineBackendUserRemovalUpdate.php:105 Unresolved

    this is useless. The wizard will mark matched records as deleted. So with the restriction removed, it will fetch delete records to delete them -.-
  12. Anja Leichsenring uploaded patch set 4 03/01/18, 21:13

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 03/01/18, 21:13

  14. TYPO3com voted on patch set 4 V +1 03/01/18, 21:25 Completed build in 12m 02s on Thu, 1 Mar, 10:25 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20399

  15. Frank Nägler commented on patch set 4 CR -1 03/02/18, 09:33

    thanks for your patch, in general I agree to this change, but in two cases, I opt for not change the behavior. please read my comments in the two update wizards.

    FormLegacyExtractionUpdate.php:63

    clear -1 for this change. why? Now the update will install old form extension also if it is not required, this update wizard should really only run if the instance contains active old forms. If an old form later is restored, this will not work, which is fine from my point of view.

    FrontendUserImageUpdateWizard.php:30

    Now, this wizard create sys_file_references for deleted records, which results in database inconsistencies. I opt for not touching this update wizard, else the created references must be deleted also. I am not sure if the recylcer works well with fal references. this area should be tested really intensive. or better leave it as it is, this kind of change not so important.
  16. Anja Leichsenring uploaded patch set 5 03/05/18, 18:51

  17. Anja Leichsenring voted on patch set 5 V +1 CR +1 03/05/18, 18:51

  18. TYPO3com voted on patch set 5 V +1 03/05/18, 19:01 Completed build in 10m 01s on Mon, 5 Mar, 08:01 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20552

  19. Jigal van Hemert voted on patch set 5 V +1 CR +1 03/06/18, 07:05

  20. Stefan Neufeind commented on patch set 5 V +1 CR +1 03/06/18, 07:06

    seems to work for me now
  21. Georg Ringer voted on patch set 5 V +2 CR +2 03/06/18, 09:20

  22. Georg Ringer merged patch set 6 03/06/18, 09:20

  23. Stephan Großberndt commented on patch set 6 03/09/18, 15:10

    Backport for 8.7 is missing
  24. Stefan Neufeind commented on patch set 6 03/09/18, 22:33

    cherry-picked it to 8.7 now