Review main Merged

52547[BUGFIX] Do not override global BE_USER for user settings simulation

Markus Klein CR +2 V +2 Normal +49 −44 updated 04/21/17, 20:09

Commit message

Instead of replacing the global user for simulating another user
to edit user settings, store the "user to edit" in the controller.

This prevents a whole lot of possible errors.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Markus Klein uploaded patch set 1 04/21/17, 19:07

  2. TYPO3com voted on patch set 1 V +1 04/21/17, 19:13 Completed build in 06m 19s on Fri, 21 Apr, 09:13 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10849

  3. Markus Klein updated the commit message in patch set 2 04/21/17, 19:19

  4. TYPO3com voted on patch set 2 V +1 04/21/17, 19:32 Completed build in 12m 35s on Fri, 21 Apr, 09:32 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10852

  5. Markus Klein uploaded patch set 3 04/21/17, 19:41

  6. TYPO3com voted on patch set 3 V +1 04/21/17, 19:50 Completed build in 09m 19s on Fri, 21 Apr, 09:50 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10854

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 04/21/17, 19:58

  8. Georg Ringer voted on patch set 3 CR +1 V +1 04/21/17, 20:04

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/21/17, 20:05

  10. Gerrit merged patch set 3 04/21/17, 20:06

  11. Christian Kuhn commented on patch set 4 04/21/17, 20:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 13042d9efd5f8e91dd499f33a288951847614ba8