Review main Merged

52558[BUGFIX] Remove call to getTabMenuRaw in AbstractLinkBrowserController

Michael Oehlhof CR +2 V +2 Easy +15 −1 updated 04/26/17, 20:39

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Michael Oehlhof uploaded patch set 1 04/22/17, 21:27

  2. Riccardo De Contardi commented on patch set 1 V +1 04/22/17, 21:32

    ok the error has gone, but now the link browser popup can only allow you to link pages. Will this be handled on a different issue?
  3. TYPO3com voted on patch set 1 V +1 04/22/17, 21:34 Completed build in 07m 29s on Sat, 22 Apr, 11:34 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10871

  4. Michael Oehlhof commented on patch set 1 V -1 04/22/17, 21:36

    It should work as before, so the item is not fixed. I have to look a bit deeper in the code.
  5. Michael Oehlhof uploaded patch set 2 04/22/17, 22:06

  6. Michael Oehlhof commented on patch set 2 CR -1 04/22/17, 22:10

    Working on it
  7. Michael Oehlhof uploaded patch set 3 04/22/17, 22:13

  8. Riccardo De Contardi voted on patch set 2 V +1 04/22/17, 22:13

  9. TYPO3com voted on patch set 2 V +1 04/22/17, 22:17 Completed build in 10m 36s on Sun, 23 Apr, 12:17 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10872

  10. TYPO3com voted on patch set 3 V +1 04/22/17, 22:24 Completed build in 10m 16s on Sun, 23 Apr, 12:24 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10873

  11. Benni Mack voted on patch set 3 CR +1 V +1 04/26/17, 18:44

  12. Georg Ringer voted on patch set 3 CR +2 V +2 04/26/17, 20:39

  13. Gerrit merged patch set 3 04/26/17, 20:39