Review main Abandoned

52559[BUGFIX] Catch exceptions in AbstractDatabaseRecordList::linkUrlMail

Georg Ringer CR 0 V 0 Easy +12 −8 updated 08/04/17, 07:35

Commit message

To avoid uncaught exceptions in the list module, any exception
should be caught in the mentioned method.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 04/23/17, 16:36

  2. TYPO3com voted on patch set 1 V -1 04/23/17, 16:49 Completed build in 12m 36s on Sun, 23 Apr, 06:49 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10876

  3. Georg Ringer uploaded patch set 2 04/24/17, 05:51

  4. TYPO3com voted on patch set 2 V +1 04/24/17, 06:01 Completed build in 09m 33s on Mon, 24 Apr, 08:01 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10890

  5. Benni Mack voted on patch set 2 CR +1 05/10/17, 05:21

  6. Wouter Wolters voted on patch set 2 CR +1 05/11/17, 12:39

  7. Jan Helke voted on patch set 2 CR +1 V +1 05/11/17, 13:18

  8. Anja Leichsenring commented on patch set 2 CR -1 05/11/17, 13:36

    AbstractDatabaseRecordList.php:1050

    should that not at least be logged? Catch and forget is probably not the best way to handle an exception.
  9. Wolfgang Klinger commented on patch set 2 07/15/17, 13:14

    this patch is obsolete imho, see https://review.typo3.org/#/c/53121/5 where the exception is catched already in validEmail
  10. Tymoteusz Motylewski commented on patch set 2 07/28/17, 11:09

    I prefer to solve the issue with this patch https://review.typo3.org/#/c/53121/5
  11. Tymoteusz Motylewski commented on patch set 2 07/31/17, 13:14

    as the other patch was merged, can we abandon this one?
  12. Georg Ringer abandoned the change 08/04/17, 07:35