52561[!!!][FEATURE] Remove sys_domain records
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 18
- typo3/sysext/backend/Classes/Tree/Pagetree/Commands.php+5 −12
- typo3/sysext/backend/Classes/Tree/View/BrowseTreeView.php+5 −17
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+10 −59
- typo3/sysext/context_help/ext_tables.phpnew+12 −0
- typo3/sysext/core/Build/Configuration/Acceptance/Support/_generated/AcceptanceTesterActions.phpnew+3023 −0
- typo3/sysext/core/Classes/Service/SiteService.phpnew+138 −0
- typo3/sysext/core/Classes/Utility/MailUtility.php+5 −18
- typo3/sysext/core/Tests/Acceptance/Step/Backend/Helper/BackendSelectors.phpnew+33 −0
- typo3/sysext/core/Tests/Unit/Service/SiteServiceTest.phpnew+113 −0
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+13 −12
- typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php+0 −23
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+4 −90
- typo3/sysext/frontend/Classes/Page/PageRepository.php+9 −54
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+0 −122
- typo3/sysext/frontend/Tests/Functional/Tca/DomainVisibleFieldsTest.phpdeleted+0 −50
- typo3/sysext/frontend/ext_tables.sql+0 −23
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+22 −22
- typo3/sysext/t3editor/Resources/Public/JavaScript/parse_typoscript/tokenizetyposcript.js+0 −1
Review log 1314
-
Georg Ringer uploaded patch set 1 04/23/17, 18:55
-
Markus Klein commented on patch set 1 04/23/17, 21:53
I somehow dislike having uids in configuration again. I want to bind domains to the page tree. domains are different on live or staging systems. -
Georg Ringer commented on patch set 1 04/24/17, 05:37
page tree can only be identified via page ids and TS is no option as it is a monster and may not be initliazed at that point. You can check in the additionalconfiguration for the application context and set domains differently. -
Georg Ringer uploaded patch set 2 06/09/17, 05:51
-
Georg Ringer uploaded patch set 3 06/09/17, 05:57
-
Georg Ringer rebased onto patch set 4 08/01/17, 17:59
-
Benni Mack commented on patch set 4 08/01/17, 21:23
How about we name it TYPO3_CONF_VARS/SYS/sites instead of "domains"? Also, one thing that might be handy if we'd do "pageId" => [ "domains" => ["mysite.com", "myseoncddomainstillvalid.com"], "languages" = [0 => "de", 1 => "en"] "redirects" => ["/" => "/de/", "www.mysite.com" => "mysite.com"] ] ? plus, one thing that would be really cool if we could keep the sys_domain records "in sync" by keeping them and updating the TYPO3_CONF_VARS via hooks in DataHandler? What do you think? -
Timo Hund commented on patch set 4 08/02/17, 07:28
Thanks for the patch Georg, i think reading the domain records from the configuration is good. I'll try to change the configuration structure as benni described. -
Timo Hund uploaded patch set 5 08/02/17, 11:11
-
TYPO3com voted on patch set 5 V -1 08/02/17, 11:11 Completed build in 11s on Wed, 2 Aug, 01:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13553
-
Timo Hund commented on patch set 5 08/02/17, 11:13
I've changed the structure for the domains, to fit bennis proposal. A question for me is by signatur getFirstDomainForPage looks like, it can resolve the domains for every pageId. Currently it only does it for the rootPageId. Who should resolve the rootPageId for a given pageId? Should we do this in the SiteService? What is the best way to do this context independent (BE&FE). -
Timo Hund uploaded patch set 6 08/02/17, 11:22
-
Benni Mack commented on patch set 6 02/06/18, 20:23
I'd actually go with a different approach now (now that we got rid of the extra sys_domain shissle). - A repository/site service which adds DB records and the ones from the config, where DB takes precedence. -
Benni Mack abandoned the change 02/08/18, 18:05
abandoned for now, will pick the concepts up separately, hope that's OK with you, Georg?