52567[BUGFIX] LinkService must handle old ?id=xyz links
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Johannes Kasberger +1
- Christer V +1
-
Verified V +2
- Benni Mack +2
- Johannes Kasberger +1
- Christer V +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1216
-
Markus Klein uploaded patch set 1 04/24/17, 12:42
-
Markus Klein commented on patch set 2 04/24/17, 12:50
Published edit on patch set 1. -
Markus Klein updated the commit message in patch set 3 04/24/17, 12:51
-
TYPO3com voted on patch set 1 V -1 04/24/17, 12:52 Completed build in 09m 28s on Mon, 24 Apr, 02:52 PM Test Summary: 222 of 55791 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10893
-
Markus Klein commented on patch set 4 04/24/17, 12:54
Published edit on patch set 3. -
TYPO3com voted on patch set 2 V +1 04/24/17, 12:59 Completed build in 09m 16s on Mon, 24 Apr, 02:59 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10894
-
TYPO3com voted on patch set 3 V +1 04/24/17, 12:59 Completed build in 08m 08s on Mon, 24 Apr, 02:59 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10895
-
Andreas Kienast commented on patch set 4 04/24/17, 13:01
LegacyLinkNotationConverter.php:88Is ../../ etc also possible? -
Andreas Kienast commented on patch set 4 04/24/17, 13:02
LegacyLinkNotationConverter.php:88Do we need to store the matches? AFAICS they are not used anywhere. -
TYPO3com voted on patch set 4 V +1 04/24/17, 13:04 Completed build in 09m 37s on Mon, 24 Apr, 03:04 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10896
-
Johannes Kasberger voted on patch set 4 CR +1 V +1 04/24/17, 13:09
-
Markus Klein commented on patch set 4 04/24/17, 13:09
LegacyLinkNotationConverter.php:88Replyshould not as the old rte magic images thingy seemed to make links relative to mainDir, which is always "..". At least our test instance here only has such links. I would say we "open up" the regex if more such cases turn up.LegacyLinkNotationConverter.php:88Replyone line below ;-) -
Christer V voted on patch set 4 CR +1 V +1 04/26/17, 12:58
-
Benni Mack voted on patch set 4 CR +2 V +2 04/26/17, 18:42
-
Gerrit merged patch set 4 04/26/17, 18:42
-
Benni Mack commented on patch set 5 04/26/17, 18:43
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f6ba9147c0bcf207b247d73766328b08a74285a7