Review main Abandoned

52582[TASK] Simplify PagePositionMap

Georg Ringer CR 0 V 0 Easy +6 −31 updated 07/05/17, 18:05

Commit message

Simplify the PagePositionMap by removing calls to
not needed methods.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1020

  1. Georg Ringer uploaded patch set 1 04/25/17, 06:33

  2. Oliver Klee voted on patch set 1 CR +1 04/25/17, 06:39

  3. TYPO3com voted on patch set 1 V -1 04/25/17, 06:43 Completed build in 09m 58s on Tue, 25 Apr, 08:43 AM Test Summary: 55712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10924

  4. Georg Ringer updated the commit message in patch set 2 04/25/17, 07:08

  5. TYPO3com voted on patch set 2 V -1 04/25/17, 07:17 Completed build in 08m 49s on Tue, 25 Apr, 09:17 AM Test Summary: 55712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10926

  6. Georg Ringer rebased onto patch set 3 04/25/17, 10:36

  7. TYPO3com voted on patch set 3 V +1 04/25/17, 10:45 Completed build in 08m 40s on Tue, 25 Apr, 12:45 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10941

  8. Oliver Klee voted on patch set 3 CR +1 04/25/17, 10:48

  9. Markus Klein commented on patch set 3 CR -1 04/25/17, 17:04

    PagePositionMap.php:521

    it's overwritten in subclass, maybe still optimizable?
  10. Georg Ringer uploaded patch set 4 04/26/17, 20:59

  11. TYPO3com voted on patch set 4 V -1 04/26/17, 21:10 Completed build in 10m 57s on Wed, 26 Apr, 11:10 PM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  12. TYPO3com commented on patch set 4 04/26/17, 21:49 Completed build in 1h 01m 38s on Wed, 26 Apr, 11:49 PM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  13. TYPO3com commented on patch set 4 04/26/17, 21:50 Completed build in 1h 53m 15s on Wed, 26 Apr, 11:50 PM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  14. TYPO3com commented on patch set 4 04/26/17, 21:55 Completed build in 2h 49m 20s on Wed, 26 Apr, 11:55 PM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  15. TYPO3com commented on patch set 4 04/26/17, 22:01 Completed build in 3h 51m 18s on Thu, 27 Apr, 12:01 AM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  16. Christian Kuhn rebased onto patch set 5 04/26/17, 22:02

  17. TYPO3com voted on patch set 5 V +1 04/26/17, 22:10 Completed build in 08m 07s on Thu, 27 Apr, 12:10 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11009

  18. TYPO3com commented on patch set 4 04/26/17, 22:34 Completed build in 5h 26m 13s on Thu, 27 Apr, 12:34 AM Test Summary: 3 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10999

  19. Markus Klein commented on patch set 5 CR -1 V -1 04/27/17, 09:15

    PagePositionMap.php:518

    overwritten in ContentLayoutPagePositionMap

    PagePositionMap.php:578

    overwritten in ContentLayoutPagePositionMap
  20. Georg Ringer abandoned the change 07/05/17, 18:05