Review main Merged

52594[BUGFIX] Properly set format of StandaloneView

Markus Klein CR +2 V +2 Easy +3 −3 updated 04/26/17, 16:31

Commit message

The internal TemplatePaths object of the BaseRenderingContext
needs to updated as well, when the format of a view is changed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Claus Due +1
    • Thomas Hohn +1
    • Johannes Kasberger +1
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Christian Kuhn +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Markus Klein uploaded patch set 1 04/25/17, 08:55

  2. TYPO3com voted on patch set 1 V -1 04/25/17, 09:06 Completed build in 11m 05s on Tue, 25 Apr, 11:06 AM Test Summary: 55712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10931

  3. Claus Due commented on patch set 1 04/25/17, 09:20

    Only the nit-pick, solution looks good to me.

    StandaloneView.php:193

    nitpick: "path" should be "paths" since you're changing the doc comment anyway :)

    TemplateView.php:18

    Technically unrelated change - fine by me though. The class has been gone for a long time now.
  4. Markus Klein commented on patch set 2 04/25/17, 11:26

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 04/25/17, 11:40 Completed build in 14m 15s on Tue, 25 Apr, 01:40 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10945

  6. Johannes Kasberger voted on patch set 2 CR +1 V +1 04/25/17, 11:43

  7. Claus Due voted on patch set 2 CR +1 04/25/17, 11:55

  8. Wouter Wolters voted on patch set 2 CR +1 04/25/17, 12:26

  9. Thomas Hohn voted on patch set 2 CR +1 04/26/17, 11:19

  10. Tymoteusz Motylewski commented on patch set 2 CR +1 04/26/17, 11:30

    sounds reasonable. any hints how to test it?
  11. Markus Klein commented on patch set 2 04/26/17, 11:43

    Added testing instructions to ticket in forge
  12. Christian Kuhn voted on patch set 2 CR +2 V +2 04/26/17, 16:30

  13. Gerrit merged patch set 2 04/26/17, 16:31

  14. Christian Kuhn commented on patch set 3 04/26/17, 16:31

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1fc1be55f5c5cfa1ce1095caf35602c4ec1abcbc