52594[BUGFIX] Properly set format of StandaloneView
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Claus Due +1
- Thomas Hohn +1
- Johannes Kasberger +1
- Wouter Wolters +1
- Tymoteusz Motylewski +1
-
Verified V +2
- Christian Kuhn +2
- Johannes Kasberger +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Markus Klein uploaded patch set 1 04/25/17, 08:55
-
TYPO3com voted on patch set 1 V -1 04/25/17, 09:06 Completed build in 11m 05s on Tue, 25 Apr, 11:06 AM Test Summary: 55712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10931
-
Claus Due commented on patch set 1 04/25/17, 09:20
Only the nit-pick, solution looks good to me.StandaloneView.php:193nitpick: "path" should be "paths" since you're changing the doc comment anyway :)TemplateView.php:18Technically unrelated change - fine by me though. The class has been gone for a long time now. -
Markus Klein commented on patch set 2 04/25/17, 11:26
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/25/17, 11:40 Completed build in 14m 15s on Tue, 25 Apr, 01:40 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10945
-
Johannes Kasberger voted on patch set 2 CR +1 V +1 04/25/17, 11:43
-
Claus Due voted on patch set 2 CR +1 04/25/17, 11:55
-
Wouter Wolters voted on patch set 2 CR +1 04/25/17, 12:26
-
Thomas Hohn voted on patch set 2 CR +1 04/26/17, 11:19
-
Tymoteusz Motylewski commented on patch set 2 CR +1 04/26/17, 11:30
sounds reasonable. any hints how to test it? -
Markus Klein commented on patch set 2 04/26/17, 11:43
Added testing instructions to ticket in forge -
Christian Kuhn voted on patch set 2 CR +2 V +2 04/26/17, 16:30
-
Gerrit merged patch set 2 04/26/17, 16:31
-
Christian Kuhn commented on patch set 3 04/26/17, 16:31
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1fc1be55f5c5cfa1ce1095caf35602c4ec1abcbc