Review main Merged

52597[TASK] Set Fluid cache backend to SimpleFileBackend

Claus Due CR +2 V +2 Easy +1 −1 updated 04/26/17, 21:01

Commit message

A significant performance increase can be achieved
by switching to this backend because FileBackend
will do excessive calls to file_get_contents.

Affects every currently supported TYPO3 version.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2225

  1. Claus Due uploaded patch set 1 04/25/17, 09:52

  2. Wouter Wolters commented on patch set 1 04/25/17, 09:54

    6.2 is EOL, no changes done to that branch anymore ;)
  3. TYPO3com voted on patch set 1 V +1 04/25/17, 10:06 Completed build in 13m 54s on Tue, 25 Apr, 12:06 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10935

  4. Claus Due updated the commit message in patch set 2 04/25/17, 10:15

  5. Claus Due commented on patch set 2 04/25/17, 10:23

    Example delta from rendering a list of 24 backend users. One partial involved. Impact: -210 calls to file_get_contents, tradeoff 106 more calls to requireOnce which is light-weight and uses file_exists + php's require_once and thus avoids re-reading the whole file.
  6. TYPO3com voted on patch set 2 V +1 04/25/17, 10:30 Completed build in 15m 23s on Tue, 25 Apr, 12:30 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10940

  7. Mads Lønne Jensen commented on patch set 2 CR +1 V +1 04/25/17, 10:34

    Verified, my Blackfire profiling show 670 saved calls to file_get_contents. -36% time saved! Claus: no tradeoffs, call from FileBackend replaced with calls in SimpleFileBackend
  8. Thomas Hohn voted on patch set 2 CR +1 04/25/17, 10:34

  9. Thomas Hohn voted on patch set 2 V +1 04/25/17, 10:35

  10. Christer V voted on patch set 2 CR +1 04/26/17, 06:29

  11. Andreas Kienast voted on patch set 2 CR +1 04/26/17, 07:40

  12. Markus Klein commented on patch set 2 CR -1 04/26/17, 08:01

    Wouldn't touch 7.6 here. If anyone cares one can adjust that in his/her sitesetup.
  13. Andreas Kienast voted on patch set 2 CR -1 04/26/17, 08:03

  14. Markus Klein updated the commit message in patch set 3 04/26/17, 09:44

  15. Markus Klein voted on patch set 3 CR +1 V +1 04/26/17, 09:44

  16. Wouter Wolters voted on patch set 3 CR +1 04/26/17, 09:45

  17. TYPO3com voted on patch set 3 V +1 04/26/17, 09:50 Completed build in 06m 18s on Wed, 26 Apr, 11:50 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10970

  18. Andreas Kienast voted on patch set 3 CR +1 04/26/17, 09:55

  19. Oliver Klee commented on patch set 3 04/26/17, 10:49

    Shouldn't this then be 7.6 as well?
  20. Thomas Hohn commented on patch set 3 CR +1 04/26/17, 11:00

    Reply

    Markus posted this comment: "Wouldn't touch 7.6 here. If anyone cares one can adjust that in his/her sitesetup."
  21. Oliver Klee voted on patch set 3 CR +1 04/26/17, 11:07

  22. Christian Kuhn voted on patch set 3 CR +2 V +2 04/26/17, 21:01

  23. Gerrit merged patch set 3 04/26/17, 21:01

  24. Christian Kuhn commented on patch set 4 04/26/17, 21:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d253ac79dc1ae4fe29b33374b04b06487898ad58