Review main Merged

52620[TASK] Streamline PageRepository->getRawRecord

Benni Mack CR +2 V +2 Easy +2 −7 updated 04/28/17, 05:31

Commit message

The fourth parameter of `PageRepository->getRawRecord()` is not
properly used nor useful for public cases and should be handled
differently in the future.

However, this patch basically just streamlines the callers' code.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Sascha Egerer +1
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 04/26/17, 19:05

  2. TYPO3com voted on patch set 1 V +1 04/26/17, 19:12 Completed build in 06m 17s on Wed, 26 Apr, 09:12 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10994

  3. Georg Ringer updated the commit message in patch set 2 04/26/17, 20:53

  4. Georg Ringer voted on patch set 2 CR +1 V +1 04/26/17, 20:53

  5. TYPO3com voted on patch set 2 V +1 04/26/17, 21:01 Completed build in 07m 19s on Wed, 26 Apr, 11:01 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10998

  6. Benni Mack commented on patch set 2 04/27/17, 05:29

    TypoScriptFrontendController.php:2606

    FYI: true does not do anything here, because sys_language is non-versionable
  7. Sascha Egerer updated the commit message in patch set 3 04/27/17, 11:44

  8. Sascha Egerer voted on patch set 3 CR +1 04/27/17, 11:44

  9. TYPO3com voted on patch set 3 V +1 04/27/17, 11:53 Completed build in 08m 50s on Thu, 27 Apr, 01:53 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11034

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 04/27/17, 13:59

  11. Andreas Kienast voted on patch set 3 CR +2 V +2 04/28/17, 05:31

  12. Gerrit merged patch set 3 04/28/17, 05:31