Review main Merged

52626[TASK] Code and comment clean up

Benni Mack CR +2 V +2 Easy +15 −20 updated 04/27/17, 11:32

Commit message

There are several places with typos, or wrong comments.

Additionally, some places still contain a check for PATH_site which dates
back to TYPO3 versions before a clean bootstrap was in place, and
where strict checks in conditions were forgotten.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Henrik Elsner +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 79

  1. Benni Mack uploaded patch set 1 04/27/17, 05:03

  2. TYPO3com voted on patch set 1 V -1 04/27/17, 05:19 Completed build in 16m 32s on Thu, 27 Apr, 07:19 AM Test Summary: 6 of 37850 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11013

  3. TYPO3com voted on patch set 1 V +1 04/27/17, 05:32 Completed build in 46m 16s on Thu, 27 Apr, 07:32 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11013

  4. Georg Ringer voted on patch set 1 CR +1 V +1 04/27/17, 06:21

  5. Thomas Hohn voted on patch set 1 CR +1 04/27/17, 06:43

  6. Henrik Elsner voted on patch set 1 CR +1 04/27/17, 07:20

  7. Wouter Wolters voted on patch set 1 CR +2 V +2 04/27/17, 11:31

  8. Gerrit merged patch set 1 04/27/17, 11:31

  9. Wouter Wolters commented on patch set 2 04/27/17, 11:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 56f4d185b650f8efb52643b0907b776793956305