Review main Merged

52627[BUGFIX] BackendUtility should not use PageRepository

Benni Mack CR +2 V +2 Easy +7 −15 updated 04/28/17, 07:40

Commit message

BackendUtility builds a PageRepository object to fetch a SQL query instead
of simply using the Deleted+HiddenRestriction themselves to fetch the first fe_group
record.

The PageRepository object does not even get initialized, so it can safely be exchanged.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Benni Mack uploaded patch set 1 04/27/17, 05:07

  2. TYPO3com voted on patch set 1 V -1 04/27/17, 05:17 Completed build in 09m 49s on Thu, 27 Apr, 07:17 AM Test Summary: 5 of 55781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11014

  3. TYPO3com voted on patch set 1 V +1 04/27/17, 05:37 Completed build in 40m 17s on Thu, 27 Apr, 07:37 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11014

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 04/27/17, 14:10

  5. Andreas Kienast commented on patch set 1 CR -1 04/27/17, 17:28

    BackendUtility.php:4266

    "fe_groups" as key doesn't exist in my instance, but "fe_group" does. Is this another bug or am I missing something?
  6. Andreas Kienast commented on patch set 1 04/27/17, 17:37

    I see, it's a regression of #80317
  7. Andreas Kienast uploaded patch set 2 04/27/17, 18:01

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 04/27/17, 18:06

  9. TYPO3com voted on patch set 2 V +1 04/27/17, 18:11 Completed build in 09m 22s on Thu, 27 Apr, 08:11 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11059

  10. Wouter Wolters commented on patch set 2 CR -1 04/27/17, 19:26

    BackendUtility.php:2518

    makeinstance here

    BackendUtility.php:3553

    makeinstance here
  11. Andreas Kienast uploaded patch set 3 04/28/17, 05:20

  12. TYPO3com voted on patch set 3 V +1 04/28/17, 05:25 Completed build in 05m 22s on Fri, 28 Apr, 07:25 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11062

  13. Andreas Kienast voted on patch set 3 CR +1 V +1 04/28/17, 05:32

  14. Wouter Wolters voted on patch set 3 CR +2 V +2 04/28/17, 07:40

  15. Gerrit merged patch set 3 04/28/17, 07:40