Review main Merged

52631[BUGFIX] Do not sort tree nodes after each append

Christer V CR +2 V +2 Easy +4 −1 updated 05/08/17, 07:52

Commit message

Nodes should not be sorted after each element append but only once at
the end.

This will reduce the execution time of 
DatabaseTreeDataProvider::buildRepresentationForNode() a lot e.g. when
a category menu tree is generated.

Review

  • Code review CR +2
    • Jan Helke +2
    • Sascha Egerer +1
    • Anders Kostending +1
    • Christer V +1
  • Verified V +2
    • Jan Helke +2
    • Sascha Egerer +1
    • Christer V +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2331

Show 36 earlier messages
  1. Christer V uploaded patch set 1 04/27/17, 09:32

  2. TYPO3com voted on patch set 1 V -1 04/27/17, 09:43 Completed build in 10m 53s on Thu, 27 Apr, 11:43 AM Test Summary: 35 of 37756 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11026

  3. TYPO3com commented on patch set 1 04/27/17, 10:33 Completed build in 1h 11m 53s on Thu, 27 Apr, 12:33 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11026

  4. TYPO3com voted on patch set 1 V +1 04/27/17, 13:10 Completed build in 4h 49m 59s on Thu, 27 Apr, 03:10 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11026

  5. Wouter Wolters voted on patch set 1 CR +1 04/27/17, 13:57

  6. Christer V rebased onto patch set 2 05/01/17, 07:53

  1. TYPO3com voted on patch set 2 V +1 05/01/17, 07:59 Completed build in 05m 49s on Mon, 1 May, 09:59 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11107

  2. Thomas Hohn voted on patch set 2 CR +1 V +1 05/01/17, 07:59

  3. Anders Kostending voted on patch set 2 CR +1 05/02/17, 06:37

  4. Sascha Egerer updated the commit message in patch set 3 05/03/17, 18:17

  5. Sascha Egerer commented on patch set 4 05/03/17, 18:23

    Published edit on patch set 3.
  6. Sascha Egerer voted on patch set 4 CR +2 V +2 05/03/17, 18:23

  7. Sascha Egerer voted on patch set 4 CR +1 V +1 05/03/17, 18:23

  8. TYPO3com voted on patch set 3 V +1 05/03/17, 18:24 Completed build in 06m 25s on Wed, 3 May, 08:24 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11181

  9. TYPO3com voted on patch set 4 V -1 05/03/17, 18:30 Completed build in 06m 38s on Wed, 3 May, 08:30 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11184

  10. Sascha Egerer commented on patch set 5 05/03/17, 18:35

    Published edit on patch set 4.
  11. Sascha Egerer voted on patch set 5 CR +1 V +1 05/03/17, 18:35

  12. TYPO3com voted on patch set 5 V -1 05/03/17, 18:41 Completed build in 05m 40s on Wed, 3 May, 08:41 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11185

  13. Christer V commented on patch set 5 CR -1 V -1 05/04/17, 06:57

    DatabaseTreeDataProvider.php:275

    Throws an exception. Cannot use object of type TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeNode as array Also this uses dataFromArray which will discart the sorting.
  14. Mads Lønne Jensen commented on patch set 5 CR -1 05/04/17, 10:47

    What was wrong with PS-3?
  15. Sascha Egerer commented on patch set 5 CR -2 05/04/17, 11:46

    sorry my fault. Will push PS-3 again
  16. Sascha Egerer uploaded patch set 6 05/04/17, 14:42

  17. Sascha Egerer commented on patch set 6 CR +1 V +1 05/04/17, 14:43

    Sorry for the hassle
  18. TYPO3com voted on patch set 6 V +1 05/04/17, 14:48 Completed build in 05m 21s on Thu, 4 May, 04:48 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11200

  19. Christer V voted on patch set 6 CR +1 V +1 05/05/17, 06:15

  20. Anders Kostending voted on patch set 6 CR +1 05/05/17, 09:34

  21. Jan Helke voted on patch set 6 CR +2 V +2 05/05/17, 17:04

  22. Gerrit merged patch set 6 05/05/17, 17:04

  23. Jan Helke commented on patch set 7 05/05/17, 17:04

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 49d264052a8500e3763e283a96a0046b5cf37764
  24. Mathias Brodala commented on patch set 7 05/08/17, 07:50

    Post +1: this extremely boosts the speed of huge category trees. Before it took several minutes, after ~20 seconds. Still bad but multiple dimensions better than before. ;-)
  25. Mathias Brodala commented on patch set 7 05/08/17, 07:52

    > Post +1: this extremely boosts the speed of huge category trees. > Before it took several minutes, after ~20 seconds. Still bad but > multiple dimensions better than before. ;-) 5164 categories BTW.