Review TYPO3_8-7 Merged

52634[TASK] Code and comment clean up

Wouter Wolters CR +2 V +2 Easy +15 −20 updated 04/27/17, 12:54

Commit message

There are several places with typos, or wrong comments.

Additionally, some places still contain a check for PATH_site which dates
back to TYPO3 versions before a clean bootstrap was in place, and
where strict checks in conditions were forgotten.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 6

Review log 59

  1. Wouter Wolters commented on patch set 1 04/27/17, 11:31

    Cherry Picked from branch master.
  2. Wouter Wolters updated the commit message in patch set 2 04/27/17, 11:32

  3. Benni Mack voted on patch set 2 CR +1 V +1 04/27/17, 11:32

  4. Wouter Wolters voted on patch set 2 CR +2 V +2 04/27/17, 11:35

  5. Gerrit merged patch set 2 04/27/17, 11:35

  6. TYPO3com commented on patch set 1 04/27/17, 11:41 Completed build in 08m 23s on Thu, 27 Apr, 01:41 PM Test Summary: 18401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-64

  7. TYPO3com commented on patch set 2 04/27/17, 11:41 Completed build in 09m 11s on Thu, 27 Apr, 01:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-65

  8. TYPO3com commented on patch set 1 04/27/17, 12:54 Completed build in 1h 30m 19s on Thu, 27 Apr, 02:54 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-64

  9. TYPO3com commented on patch set 2 04/27/17, 12:54 Completed build in 1h 31m 07s on Thu, 27 Apr, 02:54 PM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-65